-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: resources network widget #4327
Conversation
upd: Docs updated for network usage. add: Widget resorce iconChildren param added. upd: config file default options added. upd: resources units type added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This does need some work. I noted some small things on my phone but I need to take a closer look. It also won’t pass lint at the moment.
Co-authored-by: shamoon <[email protected]>
I will look at the lint issue again. I have provided answers for other change requests. As an additional feature, I have in mind to separate live network usage and total network usage, i.e. define it separately from the config, what is your opinion on this? (Those who want only one can open it from the config as they wish. Those who want both can add it by writing 2 lines in the config.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can take a look my changes, this is cleaner already.
But I'm still not happy with the aesthetics.
- This is the only widget item with two lines by default, which is a problem.
- Yes, we are not going to show both of them. I'd suggest we make the throughput and totals each their own line and the widget defaults to throughput and the totals is in the 'expanded' version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to add a tip, if you want to get the host's NIC information, then the docker container may need to be modified to |
@ramazansancar I think it would be a good idea to add this note to the documentation, otherwise some newbies might not use it, and at least some of my friends don't know the difference between docker's network modes(including me) |
The problem with doing that is it will almost certainly break existing integrations with other containers. It was always my beef with this widget but then again the same can apply to other resources in some situations |
Hi @o2e , Since I started the project with pm2 in source mode, I unfortunately have no idea what effect it will have on Docker and Kubernetes 🥲 |
I forgot to thank you. Thanks for supporting the development and pushing it forward at some point. It was a nice feature to the project. @shamoon |
upd: Docs updated for network usage.
add: Widget resorce iconChildren param added.
upd: config file default options added.
upd: resources units type added.
Proposed change
Closes #3421 (Discussion)
Type of change
Checklist: