Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Prometheus Metric service widget #4269

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

fcornelius
Copy link
Contributor

Proposed change

Adds a service widget to query prometheus metrics with PromQL queries and formats the results in a very similar way to how customapi does. I tried to combine this with the existing prometheus service widget but since the configuration for this one is quite fundamentally different I thought it makes more sense to have it in a separate widget. Let me know what you think.

image

Closes #779, #2969, #4267

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@fcornelius fcornelius force-pushed the feature/prometheus_metric branch from 8458bb8 to 666d779 Compare November 9, 2024 19:50
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks pretty good but some small notes.

There may be some edge cases but generally seems to work great
Screenshot 2024-11-09 at 4 05 12 PM

src/widgets/prometheusmetric/component.jsx Outdated Show resolved Hide resolved
src/widgets/prometheusmetric/component.jsx Outdated Show resolved Hide resolved
src/widgets/prometheusmetric/component.jsx Show resolved Hide resolved
src/widgets/prometheusmetric/component.jsx Outdated Show resolved Hide resolved
@shamoon shamoon enabled auto-merge (squash) November 10, 2024 00:06
@shamoon shamoon disabled auto-merge November 10, 2024 04:58
@shamoon shamoon enabled auto-merge (squash) November 12, 2024 00:38
@shamoon shamoon merged commit e938c3a into gethomepage:dev Nov 12, 2024
5 checks passed
@fcornelius
Copy link
Contributor Author

Hey, sorry didn't get a chance to your review your comments until now. Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants