Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Peanut widget v2 api compatibility #2526

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Fix: Peanut widget v2 api compatibility #2526

merged 3 commits into from
Dec 27, 2023

Conversation

Brandawg93
Copy link
Contributor

@Brandawg93 Brandawg93 commented Dec 27, 2023 •
edited
Loading

Fix for peanut v2 api

Closes # (issue)

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@Brandawg93 Brandawg93 mentioned this pull request Dec 27, 2023
Merged
9 tasks
@shamoon shamoon changed the title Peanut fix Fix: Peanut widget backwards compatibility Dec 27, 2023
@shamoon shamoon changed the title Fix: Peanut widget backwards compatibility Fix: Peanut widget v2 api compatibility Dec 27, 2023
@shamoon shamoon enabled auto-merge (squash) December 27, 2023 15:29
shamoon
shamoon approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@shamoon shamoon merged commit ccad62b into gethomepage:main Dec 27, 2023
2 checks passed
@Brandawg93 Brandawg93 deleted the peanut-fix branch December 27, 2023 18:13
@ghost
Copy link

ghost commented Jan 21, 2024

@Brandawg93 @shamoon Pretty sure there's still a bug within the latest homepage (0.8.5) and PeaNUT 2.3.0

PeaNUT 2.2.1 works with homepage, 2.3.0 does not.

image

@Brandawg93
Copy link
Contributor Author

Should be fixed in v2.3.1 of peanut.

@shamoon
Copy link
Collaborator

shamoon commented Jan 21, 2024

Awesome thanks Brandawg93

@Brandawg93
Copy link
Contributor Author

This is confirmed fixed now! @shamoon feel free to close this whenever.

@gethomepage gethomepage locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shamoon shamoon shamoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brandawg93 @shamoon