Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Quicklaunch shows also services without a url #2136

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

denispapec
Copy link
Contributor

Proposed change

This fix addresses the issue where quicklaunch shows all the services, even non-clickable ones, without a url.

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If adding a service widget or a change that requires it, I have added corresponding documentation changes.
  • If adding a new widget I have reviewed the guidelines.
  • If applicable, I have checked that all tests pass with e.g. pnpm lint.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon
Copy link
Collaborator

shamoon commented Oct 5, 2023

This one makes sense, thanks, but not to be pedantic but I prefer we filter before ever passing to quick launch rather than have it go through all of the filtering etc.

@shamoon shamoon added this pull request to the merge queue Oct 5, 2023
Merged via the queue into gethomepage:main with commit 40522fb Oct 5, 2023
1 check passed
Copy link
Contributor

github-actions bot commented Feb 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
@denispapec denispapec deleted the quicklaunch-cleanup branch May 5, 2024 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants