Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes removed without major version bump or deprecation notice #486

Open
caseykulm opened this issue Feb 6, 2022 · 3 comments
Open

Classes removed without major version bump or deprecation notice #486

caseykulm opened this issue Feb 6, 2022 · 3 comments
Assignees
Labels
bug Something isn't working documentation in progress

Comments

@caseykulm
Copy link

While upgrading com.getbouncer:cardscan-ui from 2.1.0020 to 2.1.0023 the build no longer works because of unresolved references:

Unresolved reference: CardScanActivityResult
Unresolved reference: CardScanActivityResultHandler
Unresolved reference: CardScanActivityResultHandler
Unresolved reference: warmUp
Unresolved reference: start
Unresolved reference: isScanResult
Unresolved reference: parseScanResult
'cardScanned' overrides nothing
Unresolved reference: CardScanActivityResult
'analyzerFailure' overrides nothing
'cameraError' overrides nothing
'canceledUnknown' overrides nothing
'enterManually' overrides nothing
'userCanceled' overrides nothing
Unresolved reference: CardScanActivityResult
Unresolved reference: CardScanActivityResult
Unresolved reference: CardScanActivityResult
Unresolved reference: CardScanActivityResult

These classes were removed without bumping the major version (which breaks semantic versioning, and was therefore unexpected https://semver.org/), and there were no deprecation notices in the code for the 2.1.0020 artifact.

Is there any sort of migration guide somewhere?

Thanks!

@awush-stripe
Copy link
Contributor

Apologies @caseykulm ! This code is currently migrating to Stripe infrastructure, and I missed this. You're correct this should have been a major version bump.

I'll update the git readme shortly with an integration example. It should be a relatively small change.

Apologies again!

@awush-stripe awush-stripe self-assigned this Feb 8, 2022
@caseykulm
Copy link
Author

All good, thanks for the response! Will check it out.

@awush-stripe
Copy link
Contributor

In the mean time, please take a look at the example app in this repo, which uses that interface.

https://github.com/getbouncer/cardscan-android/blob/master/cardscan-demo/src/main/java/com/getbouncer/cardscan/demo/LaunchActivity.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation in progress
Projects
None yet
Development

No branches or pull requests

2 participants