Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The new CardScanSheet API is not testable #492

Closed
francescocervone opened this issue Feb 24, 2022 · 2 comments · Fixed by #498
Closed

The new CardScanSheet API is not testable #492

francescocervone opened this issue Feb 24, 2022 · 2 comments · Fixed by #498
Assignees
@awush-stripe
Labels
regression

Comments

@francescocervone
Copy link

The new "not-yet-documented" CardScanSheet API (#486) does not allow clients to pass a custom ActivityResultRegistry, needed to make the activity result testable, as suggested by the official guide.
@francescocervone
Copy link
Author

This issue can be worked-around using espresso-intents.

@francescocervone francescocervone mentioned this issue Feb 25, 2022
Closed
@awush-stripe awush-stripe self-assigned this Feb 28, 2022
@awush-stripe
Copy link
Contributor

Thanks for the report @francescocervone . I'll get this added.

@awush-stripe awush-stripe mentioned this issue Mar 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awush-stripe awush-stripe

Labels
regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the activity result registry testable getbouncer/cardscan-android
2 participants
@francescocervone @awush-stripe