fix: "Add account" to "Connect Wallet" #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Accounts" (Manage accounts) - Title changed to "Wallets" - Button changed to "Connect a Wallet" - removed outdated translations
Updated "Manage Accounts" -> "Manage Wallets" "Switch Accounts" -> "Switch Wallet"
"Add a new account" -> "Connect a Wallet"
…arshRawat1/lightning-browser-extension into dev2-swap-accounts-to-wallets
AdarshRawat1
force-pushed
the
dev2-swap-accounts-to-wallets
branch
from
1b20e07 to
d33c235
Compare
AdarshRawat1
force-pushed
the
dev2-swap-accounts-to-wallets
branch
from
61569e7 to
f0a170c
Compare
This reverts commit 8a30396.
This reverts commit f0a170c.
This reverts commit ed4db7a.
This reverts commit 283adfd.
Updated the Accounts component test to correctly look for the text 'Wallets' instead of 'Accounts'. This change aligns the test with the current state of the Accounts component.
Updated the AccountMenu component test to correctly look for the text 'Switch Wallet' instead of 'Switch account'. This change aligns the test with the current state of the AccountMenu component.
|
@reneaaron @bumi @stackingsaunter The PR is ready for review. |
AdarshRawat1
added a commit
to AdarshRawat1/lightning-browser-extension
that referenced
this pull request
Dec 16, 2023
Updated instruction example for adding a new string. Depends on - getAlby#2896
1 task
reneaaron
added
next-release
|
@reneaaron I know you didn't like capitalisation. We are currently mixing both sentence and title case in buttons and dropdowns, there are 0 rules about this:
I just chose title case for this changes, I think it's slightly better but it's a matter of preference. Anyway, we can discuss it in another issue maybe and then change it all across all copy in the extension |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes _ #2872
Describe the changes you have made in this PR
"Accounts" (Manage accounts)
Current page
Updated Page
"Account settings" page
Current page
Updated Page
"Settings" page
Current page
Updated Page
"Manage accounts" --> "Manage Wallets" "Add a new account" --> "Connect a Wallet"
current
Updated
Updated "Remove account"
Modules renamed ( Important )
"options.account.account_settings" -> "options.account.wallet_settings"
"actions.remove_account" - > "actions.disconnect_wallet"
"actions.add_account" -> "actions.connect_wallet"
Link this PR to an issue [optional]
Fixes _ #2872
Type of change
(Remove other not matching type)
feat: New feature (non-breaking change which adds functionality)Checklist
- Updated Accounts test
- Updated AccountMenu test