Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Wallet Settings layout #2873

Closed
Tracked by #2871
stackingsaunter opened this issue Nov 16, 2023 · 6 comments
Closed
Tracked by #2871

Updates to Wallet Settings layout #2873

stackingsaunter opened this issue Nov 16, 2023 · 6 comments
Assignees
Labels
frontend All things frontend development related

Comments

@stackingsaunter
Copy link
Contributor

stackingsaunter commented Nov 16, 2023

Part of #2871 epic, which full desired effect can be viewed in this Figma

List of changes:

Main Wallet Settings page

CleanShot 2023-11-16 at 22 18 54@2x

  • Page title "Wallet Settings" is text-2xl/bold and has an explainer text "Settings related to this particular instance of the connected wallet. If you reconnect, settings related to keys or display name will have to be set again."
  • Each section title should be text-xl/bold
  • First section title is "General"
  • All buttons and a dropdown should be 256px
  • Updated capitalization of items (all words capitalized except "of, with, the, on" etc)

General section

Key Management section

  • Delete emoji from Key Management title
  • Nostr Public Key should not be a disabled input anymore, but just displayed npub. If it's imported, "Imported" tag can be next to the title.
    CleanShot 2023-11-16 at 22 12 23@2x

Danger Zone

  • "Danger Zone" has the same formatting like previous other sections
  • "accounts" copy changed to "wallets"
  • Danger buttons should have different visual style as they are irreversible actions
    CleanShot 2023-11-16 at 22 17 26@2x

Nostr Settings

  • Layout follows the pattern list from main settings page
  • New section added (for Alby Accounts only): "Nostr Address" - displays information if user set or not set their LN address as an identifier, and has a CTA to: https://getalby.com/lightning_addresses/{{ALBY ACCOUNT USERNAME}}/edit

CleanShot 2023-11-16 at 22 35 10@2x

CleanShot 2023-11-16 at 22 35 44@2x

@volfiros
Copy link
Contributor

volfiros commented Nov 19, 2023

@stackingsaunter Can u assign me this issue. I would like to work on it.

@stackingsaunter
Copy link
Contributor Author

@Rithvik-padma assigned for this issue, good luck!

@stackingsaunter
Copy link
Contributor Author

@Rithvik-padma hey are you still working on this? any progress?

@volfiros
Copy link
Contributor

@Rithvik-padma hey are you still working on this? any progress?

I was accompanied by some college work so I will start working on it right now.

@stackingsaunter
Copy link
Contributor Author

Hey, still planning to work on this @Rithvik-padma?

@pavanjoshi914
Copy link
Contributor

completed in #3133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend All things frontend development related
Projects
None yet
Development

No branches or pull requests

3 participants