Adding 'master' by itself #68
Conversation
The list includes 'master-slave' but does not include 'master' by itself. I think that it should. https://inclusivenaming.org/language/word-list/ https://github.com/github/renaming Signed-off-by: John Bent <[email protected]>
|
Hi @johnbent! Thanks for the PR! I prefer that any new rules that a user of woke wants to use be added to their own config file instead of being added as a default. See https://github.com/get-woke/woke#rules. That said, I do agree that master alone should be in the default rule set, but maybe with a "warning" severity, in case some orgs have not moved away from the "master" branch name yet. It might help push them along. I also see some failing tests, are you able to resolve them? |
|
Thanks @caitlinelfring . Having users maintain their own lists is the exact problem I'm hoping to solve because I think these lists should be community maintained. I don't trust myself nor other engineers in my org to always know which words are offensive. I'd much rather entrust that responsibility to a larger community. |
|
Closing in favor of #104 |
The list includes 'master-slave' but does not include 'master' by itself. I think that it should.
https://inclusivenaming.org/language/word-list/
https://github.com/github/renaming
Signed-off-by: John Bent [email protected]
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
Other information: