Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Add back case insensitivity to rule regex #110

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Conversation

caitlinelfring
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the current behavior? (You can also link to an open issue here)
I accidentally removed (?i) in #100 so it no longer matches with case insensitivity

What is the new behavior (if this is a feature change)?
Add back case insensitivity

Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
No

Other information:
Fixes #108

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #110 (0f9a235) into main (5b45f81) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   96.21%   96.22%           
=======================================
  Files          20       20           
  Lines         582      583    +1     
=======================================
+ Hits          560      561    +1     
  Misses         13       13           
  Partials        9        9           
Impacted Files Coverage Δ
pkg/rule/rule.go 93.75% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b45f81...0f9a235. Read the comment docs.

@caitlinelfring caitlinelfring merged commit 4c46b2f into main Jul 21, 2021
@caitlinelfring caitlinelfring deleted the issue/108 branch July 21, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.10.0/1 is case sensitive
1 participant