Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.10.0/1 is case sensitive #108

Closed
2 tasks done
ollien opened this issue Jul 21, 2021 · 1 comment · Fixed by #110
Closed
2 tasks done

v0.10.0/1 is case sensitive #108

ollien opened this issue Jul 21, 2021 · 1 comment · Fixed by #110
Labels
bug Something isn't working

Comments

@ollien
Copy link

ollien commented Jul 21, 2021

Thank you for creating the issue!

  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc).

woke misses a significant amount of matches in the current version due to it now being case sensitive. I believe the change from (?i)(%s) to (%s) in 2812f30 is to blame.

$ cat blah.txt
MASTER-SLAVE
$ ./woke blah.txt
No findings found.

Please include the following information:

Version of woke
$ go run main.go --version
woke version main (it's v0.10.1)
Config file

Default

Go environment
$ go version && go env
go version go1.16.5 darwin/amd64
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/nkrichevsky/Library/Caches/go-build"
GOENV="/Users/nkrichevsky/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/nkrichevsky/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/nkrichevsky/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.16.5/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.16.5/libexec/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.16.5"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/gj/6g23qq697ddc5mx6ry8ypdy80000gp/T/go-build2259988605=/tmp/go-build -gno-record-gcc-switches -fno-common"
Verbose output of running
./woke --debug blah.txt
2021-07-21T13:14:30-04:00 DBG woke version main built from 000000 on today
2021-07-21T13:14:30-04:00 DBG rules enabled rules=["whitelist","blacklist","master-slave","slave","grandfathered","man-hours","sanity","dummy","guys","whitebox","blackbox"]
2021-07-21T13:14:30-04:00 DBG adding ignorefile file=.gitignore
2021-07-21T13:14:30-04:00 DBG adding ignorefile file=.wokeignore
2021-07-21T13:14:30-04:00 DBG adding ignorefile file=.git/info/exclude
2021-07-21T13:14:30-04:00 DBG finished compiling ignores durationMS=1.544947
2021-07-21T13:14:30-04:00 DBG created new printer printer=text
2021-07-21T13:14:30-04:00 DBG process files path=blah.txt type=parallel
2021-07-21T13:14:30-04:00 DBG finished processing findings durationMS=0.14475 file=blah.txt
No findings found.
2021-07-21T13:14:30-04:00 DBG woke completed durationMS=2.35715
@ollien ollien added the bug Something isn't working label Jul 21, 2021
@caitlinelfring
Copy link
Member

Wow! Great catch, thank you! Fixing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants