Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor the WebAuthn library #4

Merged
merged 1 commit into from
Aug 7, 2023
Merged

♻️ Refactor the WebAuthn library #4

merged 1 commit into from
Aug 7, 2023

Conversation

qd-qd
Copy link
Member

@qd-qd qd-qd commented Aug 4, 2023

Write an assembly-less solution for the WebAuthn verification that is more gas efficient and easier to read.

⚠️ This solution assumes the challenge is sent to the contract encoded in Base64.

@qd-qd qd-qd changed the title wip WebAuthn.sol refacto Aug 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Changes to gas cost

Generated at commit: 57ca72516716a75d17880454183039321e506d88, compared to commit: 95a2ac7c35b0b8150b6056a57d0724a7772766b7

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
WebAuthnImplementation verify -2,182 ✅ -0.79%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
WebAuthnImplementation 1,050,894 (-28,026) verify 275,772 (-2,182) -0.79% 275,772 (-2,182) -0.79% 275,772 (-2,182) -0.79% 275,772 (-2,182) -0.79% 1 (0)

@qd-qd qd-qd changed the title WebAuthn.sol refacto ♻️ Refactor the WebAuthn library Aug 4, 2023
@qd-qd qd-qd marked this pull request as ready for review August 4, 2023 19:24
Write a assembly-less solution for the WebAuthn verification which is
more gas efficient and easier to read.
⚠️ This solution assumes the challenge is sent to the contract encoded
in Base64.
@qd-qd qd-qd merged commit 2745500 into main Aug 7, 2023
4 checks passed
@qd-qd qd-qd deleted the webauthn-refacto branch August 7, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant