Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 CI filter unrelevant tests from gas snapshot #13

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

qd-qd
Copy link
Member

@qd-qd qd-qd commented Aug 9, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Changes to gas cost

Generated at commit: 650ea27b5cca82c824275b6137bb750fef6697a9, compared to commit: d940f6efadc8772f6699fa56eca6e52cc51f00d3

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
WebAuthnImplementation _generateMessage +1,714 ❌ +48.82%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
WebAuthnImplementation 292,131 (0) _generateMessage 5,194 (+4,112) +380.04% 5,225 (+1,714) +48.82% 5,194 (+872) +20.18% 5,385 (0) 0.00% 6 (-8)

@qd-qd
Copy link
Member Author

qd-qd commented Aug 9, 2023

⚠️ Do not trust the gas diff report in this PR ⚠️

Gas consumption didn't change, we only blacklisted non-relevant tests that reverted. As those tests consumed less gas than the successful ones (as the execution is stopped before the end of the computation), the average consumption seems to raise. The logic didn't change, but the previous gas snapshots were misleading. This PR fixes that.

@qd-qd qd-qd merged commit fa3c356 into main Aug 9, 2023
3 checks passed
@qd-qd qd-qd deleted the ci-test-snapshot-filter branch August 9, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant