Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create flashcard (Frontend) #14

Merged
merged 15 commits into from
Mar 14, 2018
Merged

Create flashcard (Frontend) #14

merged 15 commits into from
Mar 14, 2018

Conversation

ryutaudo
Copy link
Contributor

@ryutaudo ryutaudo commented Mar 14, 2018 •
edited
Loading

Implementation

  • Setup for frontend Test
  • CreateCard Component and its test.
  • CreateCard Container and its test.
  • Cases for CreateCard in reducer.
  • Actions for CreateCard.

Future Work

  • Setup and connect to a server.
  • Test for Web Speech API

Related Issue

#3

@ryutaudo ryutaudo self-assigned this Mar 14, 2018
@ryutaudo ryutaudo temporarily deployed to kovoel-pr-14 March 14, 2018 07:25 Inactive
ChristianSchmidt1981
ChristianSchmidt1981 reviewed Mar 14, 2018
View reviewed changes
src/components/App.jsx Outdated
@@ -1,24 +1,31 @@
import React, { Component } from 'react';
import propTypes from 'prop-types';
import WebSpeechApi from '../utils/WebSpeechApi';
// TEST IMPLEMENTATION
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this

src/components/App.jsx Outdated
@@ -1,24 +1,31 @@
import React, { Component } from 'react';
import propTypes from 'prop-types';
import WebSpeechApi from '../utils/WebSpeechApi';
// TEST IMPLEMENTATION
// Should be deleted later
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this

src/components/App.jsx Outdated

class App extends Component {
testThis() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this

@ryutaudo ryutaudo merged commit 927cec8 into master Mar 14, 2018
@ryutaudo ryutaudo deleted the create-flashcard branch March 14, 2018 07:46
ryutaudo added a commit that referenced this pull request Apr 16, 2018
@ryutaudo
Merge pull request #14 from gerpanese/create-flashcard
0222314 
Create flashcard (Frontend)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okasato okasato okasato approved these changes

@ChristianSchmidt1981 ChristianSchmidt1981 ChristianSchmidt1981 approved these changes

Assignees

@ryutaudo ryutaudo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryutaudo @ChristianSchmidt1981 @okasato