Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9839: Ability to print image legend with an appropriate scale #9847

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented Dec 22, 2023

Description

This PR allows user to use legend options (scale) configured layer option to be used for printing along with an option to override all layer legend image icon size in the print tool

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Enhancement

Issue

What is the current behavior?

What is the new behavior?

  • User can print the legend options configured in the layer setting
  • User can override all layer's legend icon size in the print tool

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added enhancement BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch Print C169-Rennes-Métropole-2023-GeOrchestra4 Phase 4 labels Dec 22, 2023
@dsuren1 dsuren1 added this to the 2023.02.02 milestone Dec 22, 2023
@dsuren1 dsuren1 requested a review from offtherailz December 22, 2023 13:10
@dsuren1 dsuren1 self-assigned this Dec 22, 2023
@dsuren1 dsuren1 linked an issue Dec 22, 2023 that may be closed by this pull request
@offtherailz offtherailz merged commit e4a2a3a into geosolutions-it:master Jan 9, 2024
6 checks passed
@offtherailz
Copy link
Member

@ElenaGallo, could you please test this on DEV as well as it will be deployed ? Thank you

@ElenaGallo
Copy link
Contributor

Hi @dsuren1, the new behaviors work as expected but now the background legend is also visible on the legend.

How to Reproduce

  • Open a map
  • Open the printed tool
  • Enable the legend
  • Print the map

Current Result
The OSM Bright background legend is visible on the printed map.
See this printed map

@dsuren1
Copy link
Contributor Author

dsuren1 commented Jan 10, 2024

@ElenaGallo
This PR doesn't modify how the layer are filtered for printing. I believe it works as expected.

You can try the same in QA by selecting Sentinel 2 Cloudless as background and print legend

@ElenaGallo
Copy link
Contributor

ElenaGallo commented Jan 10, 2024

You can try the same in QA by selecting Sentinel 2 Cloudless as background and print legend

@dsuren1 that is correct, thanks for the clarification.

Please backport to the stable branch. Thanks

dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Jan 10, 2024
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 10, 2024
tdipisa pushed a commit that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants