Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9822 - Fix - [Annotations] Geometry title not easy to modify #9831

Merged
merged 2 commits into from
Jan 9, 2024
Merged

#9822 - Fix - [Annotations] Geometry title not easy to modify #9831

merged 2 commits into from
Jan 9, 2024

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented Dec 19, 2023

Description

This PR fixes the issue with user unable to clear geometry title on the Annotation features

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

What is the new behavior?
The user can clear and add new geometry title to the annotation's feature

  • With no title on the feature, when user select/unselect/add a new geometry, the title is replaced with default geometry title

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added this to the 2023.02.02 milestone Dec 19, 2023
@dsuren1 dsuren1 requested a review from offtherailz December 19, 2023 06:38
@dsuren1 dsuren1 self-assigned this Dec 19, 2023
@dsuren1 dsuren1 linked an issue Dec 19, 2023 that may be closed by this pull request
[Annotations] Geometry title not easy to modify #9822
Closed
@tdipisa tdipisa linked an issue Jan 8, 2024 that may be closed by this pull request
[Annotations] Geometry title not easy to modify georchestra/mapstore2-georchestra#647
Closed
@offtherailz offtherailz added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 8, 2024
offtherailz
offtherailz approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good 👍

@offtherailz offtherailz merged commit 7068bc9 into geosolutions-it:2023.02.xx Jan 9, 2024
6 checks passed
@offtherailz
Copy link
Member

@ElenaGallo, could you please test this on QA as well as deployed ? Thank you

@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offtherailz offtherailz offtherailz approved these changes

Assignees

@dsuren1 dsuren1

Labels
annotations related to the annotation tool bug C169-Rennes-Métropole-2023-GeOrchestra4 Phase 4
Projects
None yet
Milestone
2023.02.02
Development

Successfully merging this pull request may close these issues.

[Annotations] Geometry title not easy to modify [Annotations] Geometry title not easy to modify
3 participants
@dsuren1 @offtherailz @tdipisa