Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9783: implement zoom to record for parent table in dashboards #9787

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

mahmoudadel54
Copy link
Contributor

Description

In this PR, an enhancement is added for zooming to record in dashboard viewer. Implement zooming to record for Parent Table in dashboards if there are multiple maps linked with a parent table and all have the same layer dataset.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#9783

What is the current behavior?
#9783

What is the new behavior?
If multiple maps are linked to the same parent table and all contain a layer that references the same table dataset, zooming is performed for all map widgets as per usual logic.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've checked this and looks to be good

@MV88 MV88 merged commit 2556203 into geosolutions-it:master Dec 12, 2023
6 checks passed
@MV88
Copy link
Contributor

MV88 commented Dec 12, 2023

@ElenaGallo please test it in DEV

@ElenaGallo
Copy link
Contributor

Hi @tdipisa @mahmoudadel54,
I found the following problem (I don't know if it's related to this PR or this one):

  • When the table widget is disconnected from the map the 'Zoom to features' buttons remain in the table and work.

On Dashboard

dash.mp4

On Map

map.mp4

@mahmoudadel54
Copy link
Contributor Author

Hi @ElenaGallo

  • In dashboard, are you sure that map in not connected with the table widget as well?
  • In map, showing the zoom icon on table widget depends on cfg in localConfig called "enableZoomInTblWidget" as I remember

@ElenaGallo
Copy link
Contributor

ElenaGallo commented Dec 14, 2023

Hi @mahmoudadel54

In dashboard, are you sure that map in not connected with the table widget as well?

no, there are no connections. Here a dashboard example.

@mahmoudadel54
Copy link
Contributor Author

mahmoudadel54 commented Dec 14, 2023

Hi @mahmoudadel54

In dashboard, are you sure that map in not connected with the table widget as well?

no, there are no connections. Here a dashboard example.

Ok I catch it via these steps on dashboard:

  • add map widget
  • add table widget and create a connection with map
  • create a connection from map to the table
  • remove the connection from table widget that connects with map
  • remove the connection from map widget to the table

@tdipisa tdipisa added BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoom to record also for Parent Table in Dashboards
4 participants