Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9697: fix spatial filter and widget connection issues #9781

Merged
merged 2 commits into from
Dec 14, 2023
Merged

#9697: fix spatial filter and widget connection issues #9781

merged 2 commits into from
Dec 14, 2023

Conversation

mahmoudadel54
Copy link
Contributor

Description

  • Fix issue of not filtering chart widget if there is a spatial filter and user clicks on disable layer filter icon in TOC to show/hide spatial filter
  • Fix issue of not showing empty content in chart widget or 0 number in counter widget if extent not includes any features
  • write req. unit tests

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#9697

What is the current behavior?
#9697

What is the new behavior?

  • Now spatial filter is applied and reflected to chart widget if user clicks on disable spatial filter icon in TOC to show/hide spatial filter on map.
  • Empty content in chart widget + 0 number in counter widget are applied if current map extent doesn't include any features on map.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

@mahmoudadel54
geosolutions-it#9697: fix spatial filter and widget connection issues
d5ec524 
* Description:
- Fix issue of not filtering chart widget if there is a spatial filter and user clicks on disable layer filter icon in TOC to show/hide spatial filter
- Fix issue of not showing empty content in chart widget or 0 number in counter widget if extent not includes any features
- write req. unit tests
@mahmoudadel54 mahmoudadel54 added this to the 2024.01.00 milestone Dec 4, 2023
@mahmoudadel54 mahmoudadel54 requested a review from MV88 December 4, 2023 09:06
@mahmoudadel54 mahmoudadel54 self-assigned this Dec 4, 2023
@mahmoudadel54 mahmoudadel54 linked an issue Dec 4, 2023 that may be closed by this pull request
Spatial filter and widget connection #9697
Closed
1 task
MV88
MV88 requested changes Dec 13, 2023
View reviewed changes
web/client/reducers/widgets.js Outdated Show resolved Hide resolved
web/client/epics/widgetsbuilder.js Outdated Show resolved Hide resolved
@mahmoudadel54 mahmoudadel54 requested a review from MV88 December 13, 2023 15:57
@MV88 MV88 merged commit e45def9 into geosolutions-it:master Dec 14, 2023
6 checks passed
@MV88
Copy link
Contributor

MV88 commented Dec 14, 2023

@ElenaGallo please test it in DEV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MV88 MV88 MV88 approved these changes

Assignees

@mahmoudadel54 mahmoudadel54

Labels
bug C027-COMUNE_FI-2023-SUPPORT
Projects
None yet
Milestone
2024.01.00
Development

Successfully merging this pull request may close these issues.

Spatial filter and widget connection
2 participants
@mahmoudadel54 @MV88