Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9653 force load of font when fontAwesome css is loaded #9774

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Nov 29, 2023

Description

the issue was that the font (.woff etc) was not loaded until needed this caused this issue here

i've tested also loading directly .woff but in my case it was not fixing the issue, but with .woff2 it was.

we might add a second script for loading also .woff

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

Fix #9653

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@MV88 MV88 added bug annotations related to the annotation tool C027-COMUNE_FI-2023-SUPPORT labels Nov 29, 2023
@MV88 MV88 added this to the 2024.01.00 milestone Nov 29, 2023
@MV88 MV88 requested a review from allyoucanmap November 29, 2023 12:02
@MV88 MV88 self-assigned this Nov 29, 2023
@MV88 MV88 linked an issue Nov 29, 2023 that may be closed by this pull request
1 task
Copy link
Contributor

@allyoucanmap allyoucanmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied a change to the branch, please test if it's working also in your dev environment.

@MV88 MV88 requested a review from allyoucanmap November 29, 2023 14:26
@allyoucanmap allyoucanmap merged commit f466921 into geosolutions-it:master Nov 29, 2023
6 checks passed
@allyoucanmap
Copy link
Contributor

@ElenaGallo please test in DEV, thanks

@MV88
Copy link
Contributor Author

MV88 commented Nov 29, 2023

I applied a change to the branch, please test if it's working also in your dev environment.

interesting approach, I confirm it works well

@ElenaGallo
Copy link
Contributor

@MV88 now, if I change the map to 3D mode, the marker annotation is not visible.

ss.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Annotations - Icons issue in embedded maps
3 participants