Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9752: enhance geofence attribute rule editor #9753

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

mahmoudadel54
Copy link
Contributor

Description

In this PR, UI/UX enhancement are implemented for geofence attributes rule editor:

  • Highlight only the edited attributes
  • Fix style issue in grid_rules_manager

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: enhancement

Issue

#9752

What is the current behavior?
#9752

What is the new behavior?
Enhancement geofence attribute rule editor

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Description:
- Highlight only the edited attributes
- Write unit test
- Fix style issue in grid_rules_manager
@mahmoudadel54 mahmoudadel54 requested a review from MV88 November 27, 2023 15:14
@mahmoudadel54 mahmoudadel54 self-assigned this Nov 27, 2023
@mahmoudadel54 mahmoudadel54 linked an issue Nov 27, 2023 that may be closed by this pull request
6 tasks
@mahmoudadel54 mahmoudadel54 added this to the 2024.01.00 milestone Nov 27, 2023
@MV88 MV88 merged commit 0a1d17b into geosolutions-it:master Nov 27, 2023
6 checks passed
@MV88
Copy link
Contributor

MV88 commented Nov 27, 2023

@ElenaGallo testable in DEV

@MV88
Copy link
Contributor

MV88 commented Nov 27, 2023

this will need backport to c040-2023.02.xx @mahmoudadel54 can you prepare this in the meantime ?

@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 27, 2023
@mahmoudadel54
Copy link
Contributor Author

mahmoudadel54 commented Nov 27, 2023

this will need backport to c040-2023.02.xx @mahmoudadel54 can you prepare this in the meantime ?

Backport is done ---> #9755

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this pull request Nov 27, 2023
…utions-it#9753)

Description:
- Highlight only the edited attributes
- Write unit test
- Fix style issue in grid_rules_manager
MV88 pushed a commit that referenced this pull request Nov 27, 2023
Description:
- Highlight only the edited attributes
- Write unit test
- Fix style issue in grid_rules_manager
@MV88 MV88 removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 27, 2023
@ElenaGallo
Copy link
Contributor

@mahmoudadel54 @MV88 I can not access the attribute rule editor

sss.mp4

@tdipisa
Copy link
Member

tdipisa commented Nov 27, 2023

@ElenaGallo I think you can test this only in the standalone version since there is no support in the embedded one for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancing GeoFence attribute rule editor
4 participants