-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9325 enhancement: support for 'isNull' logical operator on date field in layer filter #9423
#9325 enhancement: support for 'isNull' logical operator on date field in layer filter #9423
Conversation
…or on date field in layer filter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation is good, just few changes to apply:
- use disabled prop instead of
this.props.operator === "isNull" ? '' :
to keep it consistent with string field - fix failing test
About the disabled prop,
current implementation:
Note: both UTCDateTimePicker and NumberPicker support disabled prop that could be applied as follow disabled={this.props.operator === "isNull"}
…e value input instead of hiding it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ElenaGallo please test this in dev and let us know if we can backport on 2023.02.xx, thanks. |
Test passed, @mahmoudadel54 please backport this to 2023.02.xx.Thanks |
…or on date field in layer filter (geosolutions-it#9423)
Description
It is an enhancement feature added to filter layer from attribute table. Add 'isNull' operator to date field to filter attribute table based on it.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#9325
What is the current behavior?
There was no operator for 'isNull' for date field
#9325
What is the new behavior?
'isNull' operator is added to the filter layer for date field.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information