-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9254 Add parametric image parsing to template viewer #9260
Conversation
From our meeting with @MV88 to provide this functionality, I suggested to use the current image tool, improving it at least, instead of introducing the support to markdown inside wyiswyg that may be a problem for future maintainance of the functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please remove the mixed markdown support and so the new image tool. Use the image tool present in react wysiwyg (replacing react quill)
- Check for backward compatibility with existing templates created with react quill ( I tried and it seems to work on demo map)
done both @offtherailz please review it again |
web/client/components/TOC/fragments/settings/FeatureInfoEditor.jsx
Outdated
Show resolved
Hide resolved
web/client/components/mapviews/settings/CompactRichTextEditor.jsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
….jsx Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
web/client/components/mapviews/settings/CompactRichTextEditor.jsx
Outdated
Show resolved
Hide resolved
@ElenaGallo please test it in DEV |
Description
Added possibility to insert image url in markdown
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#9254
What is the new behavior?
react-draft-wysiwyg
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
@tdipisa if we add a layer in gs-stable this would be easier for the tester