#9241 profile en long #9242

MV88 · 2023-06-21T08:43:32Z

Description

This pr introduce a new plugin called longitudinal plugin that works in combination of a new wps process gs:LongitudinalProfile that can be found here

to review this locally i suggest to install that jar in a local geoserver proxying to it and publish sfdem layer too,, you can found it here

also by default this is not enabled in main viewer and
can only added in a context

it should also not conflict with the current similar implementation here

Please check if the PR fulfills these requirements

The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

Issue

What is the current behavior?

#9241

What is the new behavior?

Now you can use the longitudinal profile plugin needs wps on geoserver

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

Yes, and I documented them in migration notes
No

Other useful information

v1.0.6

# Conflicts: # web/client/product/plugins.js

allyoucanmap

It seems this implementation is following the structure of the StreetView one. If so I think all related actions, reducers, epics and selector should be included in a folder called LongitudinalProfileTool that export as index the plugin

I'm seeing changes in the icon files but there is not a new svg icon file added to the folder

allyoucanmap · 2023-06-22T07:51:03Z

utility/eslint/index.js

@@ -1,3 +1,4 @@
+


This change seems related to a different PR #9188.
I think if we are not publishing the new package this should be removed.

I think i have to recreate my master branch to fix this

will force push without it

allyoucanmap · 2023-06-22T07:52:24Z

utility/eslint/package.json

@@ -29,6 +29,6 @@
    "eslint": ">= 7.5.0",
    "eslint-plugin-import": ">= 2.20.2",
    "eslint-plugin-no-only-tests": ">= 2.3.1",
-    "eslint-plugin-react": ">= 3.3.2"
+    "eslint-plugin-react": ">= 7.31.11"


Sime for this file:

This change seems related to a different PR #9188.
I think if we are not publishing the new package this should be removed.

correct, going to remove

web/client/epics/maplayout.js

web/client/epics/longitudinalProfile.js

web/client/plugins/longitudinalProfile/enhancers/processFile.js

web/client/plugins/longitudinalProfile/enhancers/useFile.js

web/client/themes/dark/variables.less

web/client/themes/default/ms-variables.less

web/client/plugins/LongitudinalProfileTool.jsx

allyoucanmap · 2023-06-22T10:03:45Z

Noted with @MV88 that the draw tool should be disabled in 3D viewer

Review styling using geostyler format to make the style work in 3D mode

java/printing/resources/geoserver/print/config.yaml

tdipisa

The layout of the PDF exported should be reviewed. At the moment the map is too small and the chart to big with loss of resolution. The layout should be the opposite as requested (see internal requirements document).

tdipisa

This UI is not correct

Use Profile layer instead of Referential as field name
The font size should be the same for all fields (also in tool settings)
Margins around the form should be better handled

tdipisa

A few additional points:

If you expand the chart you can't collapse it
The plugin button in the sidebar is not always rendered when you load the viewer. Maybe something connected to how the plugin lazy loading is implemented. This should be reviewed.
When you deactivate the long profile tool, the identify is not reactivated. They are not properly mutually exclusive and the deactivation of the long profile button is not well handled in one case since the button is toggled but the tool is not effectively active (see the video below)

MV88 · 2023-06-26T10:49:51Z

The layout of the PDF exported should be reviewed. At the moment the map is too small and the chart to big with loss of resolution. The layout should be the opposite as requested (see internal requirements document).

how about this one ?

Longitudinal profile_modified.pdf

MV88 · 2023-06-26T11:06:57Z

1. If you expand the chart you can't collapse it

fixed locally

2. The plugin button in the sidebar is not always rendered when you load the viewer. Maybe something connected to how the plugin lazy loading is implemented. This should be reviewed.

do you have a way to constantly reproduce this? It does not happen to me.

3. When you deactivate the long profile tool, the identify is not reactivated. They are not properly mutually exclusive and the deactivation of the long profile button is not well handled in one case since the button is toggled but the tool is not effectively active (see the video below)

i have this to check now and then I can submit a new PR

tdipisa · 2023-06-26T13:14:20Z

The layout of the PDF exported should be reviewed. At the moment the map is too small and the chart to big with loss of resolution. The layout should be the opposite as requested (see internal requirements document).

how about this one ?

Longitudinal profile_modified.pdf

There is too much empty space at the bottom. You can do the chart and the map a little bit bigger to cover also this

tdipisa · 2023-06-26T13:18:26Z

The plugin button in the sidebar is not always rendered when you load the viewer. Maybe something connected to how the plugin lazy loading is implemented. This should be reviewed.

do you have a way to constantly reproduce this? It does not happen to me.

I'm on tomcat. This is a map created from a context. The same problem happens at context level:

you create a context
right after you open it from the context admin list
the plugin is not there
you reload the browser page and the plugin is there that time

MV88 · 2023-06-26T16:34:35Z

It seems this implementation is following the structure of the StreetView one. If so I think all related actions, reducers, epics and selector should be included in a folder called LongitudinalProfileTool that export as index the plugin

probably you are right, it's a tedious fix but I can make this, in 2h
@tdipisa do I have to do it?

I'm seeing changes in the icon files but there is not a new svg icon file added to the folder

fixed, there is no new icons but I have not removed the new generated files. not an issue then

MV88 · 2023-06-26T16:45:16Z

closed in favor of this #9253

MV88 added 6 commits May 22, 2023 19:01

Proposal to enhance eslint config, plus fixing current configuration

e7d1db3

v1.0.6

Merge branch 'master' of https://github.com/geosolutions-it/MapStore2

656e54d

Merge branch 'master' of https://github.com/geosolutions-it/MapStore2

749130f

Longitudinal profile

6cc17b7

# Conflicts: # web/client/product/plugins.js

geosolutions-it#9241 Longitudinal profile

4862031

clean up

99802b0

MV88 added the C265-ATOLCD-2023-DEV_MS_CNR label Jun 21, 2023

MV88 added this to the 2023.02.00 milestone Jun 21, 2023

MV88 requested a review from allyoucanmap June 21, 2023 08:43

MV88 self-assigned this Jun 21, 2023

MV88 added 3 commits June 21, 2023 11:00

fix build

df18a37

fix typo

05924e8

fix icons

7ec23f3

MV88 marked this pull request as ready for review June 21, 2023 09:27

tdipisa linked an issue Jun 21, 2023 that may be closed by this pull request

Longitudinal profile plugin #9241

Closed

25 tasks

allyoucanmap requested changes Jun 22, 2023

View reviewed changes

tdipisa requested changes Jun 22, 2023

View reviewed changes

java/printing/resources/geoserver/print/config.yaml Outdated Show resolved Hide resolved

tdipisa requested changes Jun 22, 2023

View reviewed changes

tdipisa requested a review from offtherailz June 26, 2023 08:26

MV88 mentioned this pull request Jun 26, 2023

Harmonize and improve the way we specify supported projection in configuration #9249

Open

6 tasks

Fixed review changes

844a7d3

MV88 closed this Jun 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#9241 profile en long #9242

#9241 profile en long #9242

MV88 commented Jun 21, 2023

allyoucanmap left a comment

allyoucanmap Jun 22, 2023

MV88 Jun 23, 2023

allyoucanmap Jun 22, 2023

MV88 Jun 23, 2023

allyoucanmap commented Jun 22, 2023 •

edited by MV88

Loading

tdipisa left a comment

tdipisa left a comment •

edited

Loading

tdipisa left a comment •

edited

Loading

MV88 commented Jun 26, 2023

MV88 commented Jun 26, 2023

tdipisa commented Jun 26, 2023

tdipisa commented Jun 26, 2023 •

edited

Loading

MV88 commented Jun 26, 2023

MV88 commented Jun 26, 2023

#9241 profile en long #9242

#9241 profile en long #9242

Conversation

MV88 commented Jun 21, 2023

Description

Issue

Breaking change

Other useful information

allyoucanmap left a comment

Choose a reason for hiding this comment

allyoucanmap Jun 22, 2023

Choose a reason for hiding this comment

MV88 Jun 23, 2023

Choose a reason for hiding this comment

allyoucanmap Jun 22, 2023

Choose a reason for hiding this comment

MV88 Jun 23, 2023

Choose a reason for hiding this comment

allyoucanmap commented Jun 22, 2023 • edited by MV88 Loading

tdipisa left a comment

Choose a reason for hiding this comment

tdipisa left a comment • edited Loading

Choose a reason for hiding this comment

tdipisa left a comment • edited Loading

Choose a reason for hiding this comment

MV88 commented Jun 26, 2023

MV88 commented Jun 26, 2023

tdipisa commented Jun 26, 2023

tdipisa commented Jun 26, 2023 • edited Loading

MV88 commented Jun 26, 2023

MV88 commented Jun 26, 2023

allyoucanmap commented Jun 22, 2023 •

edited by MV88

Loading

tdipisa left a comment •

edited

Loading

tdipisa left a comment •

edited

Loading

tdipisa commented Jun 26, 2023 •

edited

Loading