Bugfix: Link for shared maps without context #10726
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use the share functionality in a map, that is not created out of a context, the shared link will not show the correct center and zoom, as long as the /config part in the URL is missing. As the documentations states in https://docs.mapstore.geosolutionsgroup.com/en/latest/developer-guide/map-query-parameters/#center-zoom and in https://docs.mapstore.geosolutionsgroup.com/en/latest/developer-guide/map-query-parameters/#marker-zoom that such a /config part should be part of configured URLs, this fix adds the /config part Test is adapted to the new solution. Bugfix on behalf of DB Systel GmbH
|
when you the /config part is because you are accessing to the default config map, it could have been called
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use the share functionality in a map, that is not created out of a context, the shared link will not show the correct center and zoom, as long as the /config part in the URL is missing.
As the documentations states in
https://docs.mapstore.geosolutionsgroup.com/en/latest/developer-guide/map-query-parameters/#center-zoom and in
https://docs.mapstore.geosolutionsgroup.com/en/latest/developer-guide/map-query-parameters/#marker-zoom that such a /config part should be part of configured URLs, this fix adds the /config part
Test is adapted to the new solution.
Bugfix on behalf of DB Systel GmbH
Description
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
If you use the share functionality in a map, that is not created out of a context, the shared link will not show the correct center and zoom, as long as the /config part in the URL is missing.
The documentations states in
https://docs.mapstore.geosolutionsgroup.com/en/latest/developer-guide/map-query-parameters/#center-zoom and in
https://docs.mapstore.geosolutionsgroup.com/en/latest/developer-guide/map-query-parameters/#marker-zoom that such a /config part should be part of configured URLs.
What is the new behavior?
As the documentations states in
https://docs.mapstore.geosolutionsgroup.com/en/latest/developer-guide/map-query-parameters/#center-zoom and in
https://docs.mapstore.geosolutionsgroup.com/en/latest/developer-guide/map-query-parameters/#marker-zoom that such a /config part should be part of configured URLs, this fix adds the /config part.
So now if you use the share functionality in a map, even if it is not created out of a context, the shared link will show the correct center and zoom.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
Bugfix on behalf of DB Systel GmbH