-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10684: Legend filtering for GeoServer WMS layers #10718
#10684: Legend filtering for GeoServer WMS layers #10718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning message is showing up also in the following conditions:
- the map view extent does not contain the visible layer features. This is more complex to detect
warning-message-legend-2.mp4
- the filter button is deactivated (the one inline with the layer TOC node). In this case the message should be avoided completely because legend filters are not applicable
warning-message-legend.mp4
@tdipisa @dsuren1 I think for the moment we could solve the second point when deactivated the message should never show up. The first point is technically correct but maybe the message could be misleading
web/client/plugins/TOC/components/__tests__/StyleBasedWMSJsonLegend-test.jsx
Show resolved
Hide resolved
shall we modify the warning text to either of this? Applied legend filters are incompatible with the active layer filter, or the map view extent does not contain visible layer features. Click on reset to remove legend filters or Legend filters are incompatible with the active layer filter, or no visible features are within the map view. Click reset to clear legend filters. |
@dsuren1 this seems fine |
Description
This PR implements legend filtering of the WMS layer including both the formats (image and json). Incorporates filtering factoring map extents and additional layer filter and interactions between them. Applicable for both 2D and 3D map along with legend widget. Implement reset legend when filter are incompatible
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
What is the new behavior?
Layer and legend filtering
legend_filtering.mp4
Legend filtering in printing
Applies to dashboard legend widget
Applicable for both 2D and 3D map
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information