Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10692 print bug when trying to print #10706

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Dec 3, 2024

Description

The print was no longer printing and latest bump of react-pdf was quite important, because we went from

"react-pdf": "5.1.0", (old)
"react-pdf": "7.7.3", (new)

See the commit here

here you can see that they suggest to Configure PDF.js worker by importing it
https://www.npmjs.com/package/react-pdf/v/7.7.3

Also they suggest to add

  • Support for annotations
  • Support for text layer

which are the css files imported

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#10692

What is the new behavior?

this is back printing as expected
image

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@MV88 MV88 added this to the 2025.01.00 milestone Dec 3, 2024
@MV88 MV88 requested a review from tdipisa December 3, 2024 10:08
@MV88 MV88 self-assigned this Dec 3, 2024
@MV88 MV88 changed the title 10692 print bug Fix #10692 print bug when trying to print Dec 3, 2024
@tdipisa tdipisa requested review from offtherailz and removed request for tdipisa December 3, 2024 11:00
@tdipisa tdipisa linked an issue Dec 3, 2024 that may be closed by this pull request
1 task
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As reported to be working, I approve.
#10692 (comment)

@offtherailz offtherailz merged commit 9e07128 into geosolutions-it:master Dec 6, 2024
6 checks passed
@offtherailz
Copy link
Member

@ElenaGallo, could you please test this on DEV ? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print bug in DEV
2 participants