-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10648: Issue editing multiple fields in MapStore Attribute Table #10651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibute Table Description: - edit in update wfs-t xml payload in case of multi-edit in each sigle row - add unit test for 'savePendingFeatureGridChanges'
1 task
MV88
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a test
…from epics/featuregrid to FeatureGridUtils file and a unit test is added for it.
MV88
approved these changes
Nov 5, 2024
@ElenaGallo please test it in DEV |
tdipisa
added
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Nov 5, 2024
Test passed, @mahmoudadel54 please backport to 2024.02.xx. Thanks |
rmelarab-ngs
pushed a commit
to ngsllc/MapStore2
that referenced
this pull request
Nov 5, 2024
…ibute Table (geosolutions-it#10651) * geosolutions-it#10648: Issue editing multiple fields in MapStore Attribute Table Description: - edit in update wfs-t xml payload in case of multi-edit in each sigle row - add unit test for 'savePendingFeatureGridChanges' * geosolutions-it#10648: move 'createChangesTransaction' util function from epics/featuregrid to FeatureGridUtils file and a unit test is added for it. * geosolutions-it#10648: handle unit test for 'savePendingFeatureGridChanges' * geosolutions-it#10648: edit jsdoc for util 'createChangesTransaction'
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Nov 6, 2024
…ibute Table (geosolutions-it#10651) * geosolutions-it#10648: Issue editing multiple fields in MapStore Attribute Table Description: - edit in update wfs-t xml payload in case of multi-edit in each sigle row - add unit test for 'savePendingFeatureGridChanges' * geosolutions-it#10648: move 'createChangesTransaction' util function from epics/featuregrid to FeatureGridUtils file and a unit test is added for it. * geosolutions-it#10648: handle unit test for 'savePendingFeatureGridChanges' * geosolutions-it#10648: edit jsdoc for util 'createChangesTransaction'
tdipisa
removed
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Nov 6, 2024
Merged
12 tasks
MV88
pushed a commit
that referenced
this pull request
Nov 6, 2024
…tore Attribute Table (#10651) (#10653) * #10648: Issue editing multiple fields in MapStore Attribute Table (#10651) * #10648: Issue editing multiple fields in MapStore Attribute Table Description: - edit in update wfs-t xml payload in case of multi-edit in each sigle row - add unit test for 'savePendingFeatureGridChanges' * #10648: move 'createChangesTransaction' util function from epics/featuregrid to FeatureGridUtils file and a unit test is added for it. * #10648: handle unit test for 'savePendingFeatureGridChanges' * #10648: edit jsdoc for util 'createChangesTransaction' * #10648: fix FE test failure for - Issue editing multiple fields in MapStore Attribute Table (#10654) * #10648: fix FE tests failure for savePendingFeatureGridChanges * #10648: remove unit test of 'savePendingFeatureGridChanges'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10648
What is the current behavior?
#10648
What is the new behavior?
The save operation in user makes multi-edits for each feature row data, it saves properly as expected.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information