Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10648: Issue editing multiple fields in MapStore Attribute Table #10651

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

mahmoudadel54
Copy link
Contributor

Description

This PR includes:

  • edit in update wfs-t xml payload in case of multi-edit in each sigle row
  • add unit test for 'savePendingFeatureGridChanges'

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#10648

What is the current behavior?
#10648

What is the new behavior?
The save operation in user makes multi-edits for each feature row data, it saves properly as expected.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

…ibute Table

Description:
- edit in update wfs-t xml payload in case of multi-edit in each sigle row
- add unit test for 'savePendingFeatureGridChanges'
Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a test

web/client/epics/featuregrid.js Outdated Show resolved Hide resolved
…from epics/featuregrid to FeatureGridUtils file and a unit test is added for it.
@mahmoudadel54 mahmoudadel54 requested a review from MV88 November 5, 2024 13:56
web/client/utils/FeatureGridUtils.js Outdated Show resolved Hide resolved
@mahmoudadel54 mahmoudadel54 requested a review from MV88 November 5, 2024 15:38
@MV88 MV88 merged commit ccd0c60 into geosolutions-it:master Nov 5, 2024
6 checks passed
@MV88
Copy link
Contributor

MV88 commented Nov 5, 2024

@ElenaGallo please test it in DEV

@tdipisa tdipisa added this to the 2024.02.01 milestone Nov 5, 2024
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 5, 2024
@ElenaGallo
Copy link
Contributor

Test passed, @mahmoudadel54 please backport to 2024.02.xx. Thanks

rmelarab-ngs pushed a commit to ngsllc/MapStore2 that referenced this pull request Nov 5, 2024
…ibute Table (geosolutions-it#10651)

* geosolutions-it#10648: Issue editing multiple fields in MapStore Attribute Table
Description:
- edit in update wfs-t xml payload in case of multi-edit in each sigle row
- add unit test for 'savePendingFeatureGridChanges'

* geosolutions-it#10648: move 'createChangesTransaction' util function from epics/featuregrid to FeatureGridUtils file and a unit test is added for it.

* geosolutions-it#10648: handle unit test for 'savePendingFeatureGridChanges'

* geosolutions-it#10648: edit jsdoc for util 'createChangesTransaction'
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this pull request Nov 6, 2024
…ibute Table (geosolutions-it#10651)

* geosolutions-it#10648: Issue editing multiple fields in MapStore Attribute Table
Description:
- edit in update wfs-t xml payload in case of multi-edit in each sigle row
- add unit test for 'savePendingFeatureGridChanges'

* geosolutions-it#10648: move 'createChangesTransaction' util function from epics/featuregrid to FeatureGridUtils file and a unit test is added for it.

* geosolutions-it#10648: handle unit test for 'savePendingFeatureGridChanges'

* geosolutions-it#10648: edit jsdoc for util 'createChangesTransaction'
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 6, 2024
MV88 pushed a commit that referenced this pull request Nov 6, 2024
…tore Attribute Table (#10651) (#10653)

* #10648: Issue editing multiple fields in MapStore Attribute Table (#10651)

* #10648: Issue editing multiple fields in MapStore Attribute Table
Description:
- edit in update wfs-t xml payload in case of multi-edit in each sigle row
- add unit test for 'savePendingFeatureGridChanges'

* #10648: move 'createChangesTransaction' util function from epics/featuregrid to FeatureGridUtils file and a unit test is added for it.

* #10648: handle unit test for 'savePendingFeatureGridChanges'

* #10648: edit jsdoc for util 'createChangesTransaction'

* #10648: fix FE test failure for - Issue editing multiple fields in MapStore Attribute Table (#10654)

* #10648: fix FE tests failure for savePendingFeatureGridChanges

* #10648: remove unit test of  'savePendingFeatureGridChanges'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue editing multiple fields in MapStore Attribute Table
4 participants