Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make COG download metadata by default #9590

Closed
1 of 6 tasks
Tracked by #9593
offtherailz opened this issue Oct 12, 2023 · 2 comments · Fixed by #9687 or #9713
Closed
1 of 6 tasks
Tracked by #9593

Make COG download metadata by default #9590

offtherailz opened this issue Oct 12, 2023 · 2 comments · Fixed by #9687 or #9713

Comments

@offtherailz
Copy link
Member

offtherailz commented Oct 12, 2023

Description

This option is necessary to allow zoom to layer and to get the data projection (see #9589 )

The reason why it was optional was because for big geotiffs it can take minutes.

We can overcome to this problem by:

  • Allowing to preload this data in catalog add/edit form. Because this takes a long time, a botton should allow it (with the option to cancel), and this information will be saved in the catalog, among the records. This means that also the UI with the URL(s) may need a revision, probably with a list of records, or we may have undefined behaviors when we edit URLs.
  • Store the data in the catalog so they do not have to be reloaded anymore. The user will have to refresh the metadata in catalog to reload the metadata and re-save if something changes.
  • Store these data in the layer too, so they will be available for

The metadata stored in layers/records should provide at least data about:

  • data projection and bbox
  • bands

These data can be refreshed for the styling tool (or if was not originally saved)

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information

@tdipisa tdipisa mentioned this issue Oct 12, 2023
6 tasks
@tdipisa tdipisa added this to the 2023.02.01 milestone Oct 12, 2023
@tdipisa tdipisa assigned dsuren1 and unassigned tdipisa Oct 13, 2023
@tdipisa tdipisa added Internal BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Oct 13, 2023
@tdipisa tdipisa assigned offtherailz and unassigned dsuren1 Oct 13, 2023
@tdipisa tdipisa assigned dsuren1 and unassigned offtherailz Nov 3, 2023
@dsuren1
Copy link
Contributor

dsuren1 commented Nov 7, 2023

@tdipisa @offtherailz

Updated acceptance criteria

  • Enable download metadata option by default to fetch metadata on save
  • Change the text of the checkbox field to Download file metadata on save
    - Hide cancel button on save and replace with a Cancel request button when metdata is being fetched
  • Additional layer metadata info should be saved in this format
sourceMetadata: {
  crs: "",
 // some basic metadata info
}

@tdipisa
Copy link
Member

tdipisa commented Nov 8, 2023

@dsuren1 @offtherailz
support for bands is already captured by #9588 therefore all related aspects should be reported there and worked separately.

@dsuren1 dsuren1 linked a pull request Nov 9, 2023 that will close this issue
5 tasks
@ElenaGallo ElenaGallo self-assigned this Nov 17, 2023
dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Nov 17, 2023
@ElenaGallo ElenaGallo added Accepted and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Nov 20, 2023
@dsuren1 dsuren1 mentioned this issue Mar 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment