Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COG layers regression #10072

Closed
1 task done
offtherailz opened this issue Mar 14, 2024 · 8 comments
Closed
1 task done

COG layers regression #10072

offtherailz opened this issue Mar 14, 2024 · 8 comments
Assignees
Milestone

Comments

@offtherailz
Copy link
Member

offtherailz commented Mar 14, 2024

Description

When trying to add l COG layers to the map, I have the warning about projection (to check) and the zoom button do not appear anymore.

How to reproduce

Expected Result
Selecting layers in the TOC, they have a zoom button

Current Result
Selecting layers in the TOC, they do not have a zoom button
A popup with projection issue is shown, but theoretically, properly configuring projectionDefs, it shouldn't.

screencast-mail.google.com-2024.03.14-18_23_07.webm
  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

@tdipisa
Copy link
Member

tdipisa commented Mar 14, 2024

@offtherailz is the zoom to layer working when you add the layer from catalog? It should, if not we have to fix also this and if the CRS is supported in projDefs the orange popup should not appear in theory. All this points should be included in the things to fix if you confirm that.

@offtherailz
Copy link
Member Author

I confirm. Both looks to have problems.

@offtherailz
Copy link
Member Author

added the point to current result

@dsuren1
Copy link
Contributor

dsuren1 commented Mar 19, 2024

@offtherailz @tdipisa
The occurrence of this scenario is attributed to the absence of metadata information within the COG layer (this causes, warning on projection data missing, style banding misinformation). After this issue #9590, we have limited the metadata fetch and cancelling to only cog catalog service on save and not on search.

If we allow it also on search, then with current implementation, we may not be able to cancel the metadata fetch (if data is too big).

  • Should we also allow it on search and also introduce a cancel button (limit to only cog service) on Catalog search panel?
  • Or display a notification when metadata is missing for cog layers on search?

@tdipisa
Copy link
Member

tdipisa commented Mar 19, 2024

@dsuren1 @offtherailz

... we have limited the metadata fetch and cancelling to only cog catalog service on save and not on search.

This is not so clear for me. I remember we have decided to fetch metadata by default which is the aim of #9590 therefore metadata should be downloaded and used as expected. Did I miss something maybe? @offtherailz any feedback on that?

@offtherailz
Copy link
Member Author

offtherailz commented Mar 19, 2024

The metadata information is foundamental for properly handling the correct projection and zoom to the image.
So if we download it only on catalog save, for performance reasons, we must save metadata in the catalog json, in order to be reused. I supposed it already worked like this. I don't remember if I tested it
Otherwise is better to download metadata on search or on add and wait eons.

Also the issue says

Because this takes a long time, a button should allow it (with the option to cancel), and this information will be saved in the catalog, among the records.

So if it is not a regression, anyway it is a missing in the implementation that we need to fix, or the functionality is almost unuseful.

So please @dsuren1 make sure that the metadata information is not used only on the fly when the user save, but saved in the map json (catalog) and maintained across reloads/imports etc...

Ideally, if they are not present, should be loaded in any case at some stage.

@dsuren1
Copy link
Contributor

dsuren1 commented Mar 19, 2024

So please @dsuren1 make sure that the metadata information is not used only on the fly when the user save, but saved in the map json (catalog) and maintained across reloads/imports etc...

Sure. I will make the necessary changes 👍

@tdipisa
Copy link
Member

tdipisa commented Mar 19, 2024

Closed in favor of #10083

@tdipisa tdipisa closed this as completed Mar 19, 2024
@tdipisa tdipisa self-assigned this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants