Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing #6

Merged
merged 5 commits into from
Jan 14, 2019
Merged

Contributing #6

merged 5 commits into from
Jan 14, 2019

Conversation

lheagy
Copy link
Member

@lheagy lheagy commented Jan 12, 2019

Create a contributor guide for geosci-labs. Please take a look here: https://github.com/geoscixyz/geosci-labs/blob/contributing/CONTRIBUTING.md

This discusses guidelines for contributing code, new notebooks and trying to maintain a consistent structure (as discussed in #3).

Please feel free to add your comments and suggestions!

@lheagy
Copy link
Member Author

lheagy commented Jan 12, 2019

@yangdikun, @jiajiasun: would you mind taking a look at this and seeing if you think it makes sense? Thanks!

@jiajiasun
Copy link

@lheagy I just read through the guide your put together. Excellent! It also brings me up to date on a few things (e.g., code formatting, code testing, etc).

@lheagy
Copy link
Member Author

lheagy commented Jan 14, 2019

Thanks @jiajiasun: would you mind approving this pr if you are happy with it? This is the same review process we will use for all changes to the code-base

image

image

Copy link

@jiajiasun jiajiasun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@lheagy lheagy merged commit 26baf2c into master Jan 14, 2019
@lheagy lheagy deleted the contributing branch January 14, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants