-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes towards achieving bit-for-bit reproducibility in GC-Classic upon restart #2521
base: main
Are you sure you want to change the base?
Commits on Jun 8, 2024
-
Simplified and removed unnecessary codes
- use AerMass in OCPISOA to avoid unnecessary recalculation - removed unnecessary OCPI reference when SVPOA is activated
Configuration menu - View commit details
-
Copy full SHA for 81912e0 - Browse repository at this point
Copy the full SHA 81912e0View commit details -
Supported SVPOA in SNAOM parameterized effective radius
- replace verbose representation of SOA and OCPI with OCPISOA
Configuration menu - View commit details
-
Copy full SHA for f79c946 - Browse repository at this point
Copy the full SHA f79c946View commit details
Commits on Jun 12, 2024
-
Fixed bug only including Isoprene SOA OC for TotalOC in complexSOA_no…
…nSVPOA - also includes some rewrites for better readability
Configuration menu - View commit details
-
Copy full SHA for 2592c6d - Browse repository at this point
Copy the full SHA 2592c6dView commit details
Commits on Jun 26, 2024
-
Add fixes for ALK4 and R4N2 chemistry from Brewer et al. (2023, JGR)
R4N2 was a common product of alkane, isoprene, and monoterpene oxidation and produced organonitrate SOA but we don’t want ALK4 to produce organonitrate SOA as discusses in #1625. A fix from Jared Brewer is included here. NOTE: The KPP fullchem mechanism has not been rebuilt with these fixes to facilitate merging these updates up to the latest GEOS-Chem release. These updates will also need to be added to the custom.eqn file. Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5709742 - Browse repository at this point
Copy the full SHA 5709742View commit details
Commits on Jul 2, 2024
-
Add KPP_AbsTol and KPP_RelTol to species_database.yml
run/shared/species_database.yml run/shared/species_database_hg.yml - Allow for KPP_AbsTol and KPP_RelTol tags. - Set KPP_AbsTol to 1.0e25 for all dummy species, in order to prevent these from being considered when computing the error norm. Headers/species_mod.F90 - Add KPP_AbsTol and KPP_RelTol to the Species derived type Headers/species_database_mod.F90 - Add "KPP_AbsTol" and "KPP_RelTol" to the tags array - Add code to parse KPP_AbsTol and KPP_RelTol tags - Remove the "places" keyword and just pass the number of decimal places, for a consistent appearance - Trimmed trailing whitespace - Updated comments Headers/state_chem_mod.F90 - Add KPP_AbsTol and KPP_RelTol 1-D arrays. These are initialized at the same time as the Map_KppVar mapping array. This will allow us to replace missing values at initialization, and just copy the values to ATOL and RTOL each timestep. This is more efficient. GeosCore/fullchem_mod.F90 GeosCore/mercury_mod.F90 - Replace missing values in State_Chm%KPP_AbsTol and State_Chm%KPP_RelTol with default values. This preserves the absolute and relative tolerances for species that were specified in species_database.yml. - Copy State_Chm%KPP_AbsTol to the KPP ATOL array - Copy State_Chm%KPP_RelTol to the KPP RTOL array Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 59d5a8f - Browse repository at this point
Copy the full SHA 59d5a8fView commit details -
Update CHANGELOG for KPP_AbsTol and KPP_RelTol updates
CHANGELOG.md - Added notes describing how we can now define KPP absolute and relative tolerances for species in species_database.yml Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9f22811 - Browse repository at this point
Copy the full SHA 9f22811View commit details -
In roundoff_mod.F90, cast first, then round off if places > 0
Headers/roundoff_mod.F90 - Bug fix: First cast to dble or flex. Then round off if the places argument is > 0. This allows us to just cast w/o rounding off if needed. run/shared/species_database_mod.F90 - Changed 1.0e+25_8 to 1.0e+25 in for KPP_AbsTol (LBRO2H) CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0952b24 - Browse repository at this point
Copy the full SHA 0952b24View commit details -
Fixed typo in fullchem_mod.F90
GeosCore/fullchem_mod.F90 - Removed extraneous "<" character Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 813ea43 - Browse repository at this point
Copy the full SHA 813ea43View commit details
Commits on Jul 3, 2024
-
Merge PR #2359 (Set KPP dummy species to large ATOL value)
This merge brings PR #2359 (Allow per-species definition of KPP absolute and relative solver tolerances; Set absolute tolerances of dummy species to large value, by @yantosca) into the GEOS-Chem 14.5.0 development stream. This PR adds structural updates to allow per-species setting of the KPP absolute & relative tolerances. This now allows us to assign a large absolute tolerance (1e25) to KPP dummy species, which excludes them from the error norm computations. This results in a faster simulation at the cost of numerical noise. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4288f0d - Browse repository at this point
Copy the full SHA 4288f0dView commit details
Commits on Jul 8, 2024
-
Merge GCHP hotfix from PR #2363 on top of PR #2359
This merge brings the hotfix from PR #2363 (Update setCommonRunSettings.template) on top of PR #2359. This will allow GCHP benchmarks on the cloud to proceed. Signed-off-by: Bob Yantosca <[email protected]
Configuration menu - View commit details
-
Copy full SHA for e61a510 - Browse repository at this point
Copy the full SHA e61a510View commit details
Commits on Jul 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e86648f - Browse repository at this point
Copy the full SHA e86648fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 006d012 - Browse repository at this point
Copy the full SHA 006d012View commit details
Commits on Jul 15, 2024
-
Add KPP_AbsTol and KPP_RelTol to species_database.yml
run/shared/species_database.yml run/shared/species_database_hg.yml - Allow for KPP_AbsTol and KPP_RelTol tags. - Set KPP_AbsTol to 1.0e25 for all dummy species, in order to prevent these from being considered when computing the error norm. Headers/species_mod.F90 - Add KPP_AbsTol and KPP_RelTol to the Species derived type Headers/species_database_mod.F90 - Add "KPP_AbsTol" and "KPP_RelTol" to the tags array - Add code to parse KPP_AbsTol and KPP_RelTol tags - Remove the "places" keyword and just pass the number of decimal places, for a consistent appearance - Trimmed trailing whitespace - Updated comments Headers/state_chem_mod.F90 - Add KPP_AbsTol and KPP_RelTol 1-D arrays. These are initialized at the same time as the Map_KppVar mapping array. This will allow us to replace missing values at initialization, and just copy the values to ATOL and RTOL each timestep. This is more efficient. GeosCore/fullchem_mod.F90 GeosCore/mercury_mod.F90 - Replace missing values in State_Chm%KPP_AbsTol and State_Chm%KPP_RelTol with default values. This preserves the absolute and relative tolerances for species that were specified in species_database.yml. - Copy State_Chm%KPP_AbsTol to the KPP ATOL array - Copy State_Chm%KPP_RelTol to the KPP RTOL array Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for efa425c - Browse repository at this point
Copy the full SHA efa425cView commit details -
Update CHANGELOG for KPP_AbsTol and KPP_RelTol updates
CHANGELOG.md - Added notes describing how we can now define KPP absolute and relative tolerances for species in species_database.yml Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8129a60 - Browse repository at this point
Copy the full SHA 8129a60View commit details -
In roundoff_mod.F90, cast first, then round off if places > 0
Headers/roundoff_mod.F90 - Bug fix: First cast to dble or flex. Then round off if the places argument is > 0. This allows us to just cast w/o rounding off if needed. run/shared/species_database_mod.F90 - Changed 1.0e+25_8 to 1.0e+25 in for KPP_AbsTol (LBRO2H) CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fd5541a - Browse repository at this point
Copy the full SHA fd5541aView commit details -
Fixed typo in fullchem_mod.F90
GeosCore/fullchem_mod.F90 - Removed extraneous "<" character Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b0ec470 - Browse repository at this point
Copy the full SHA b0ec470View commit details -
Update setCommonRunSettings.sh.template
Fix typo for MassFlux_Entry
Configuration menu - View commit details
-
Copy full SHA for eabf06c - Browse repository at this point
Copy the full SHA eabf06cView commit details
Commits on Jul 16, 2024
-
Merge PR #2315 (Fix bugs in PDER, OCPISOA, and TotalOC)
This merge brings PR #2315 (ix bugs in PDER, OCPISOA and TotalOC in complexSOA, by @yuanjianz) into the GEOS-Chem 14.5.0 development stream. This PR fixes several minor bugs in the complex SOA scheme as described in issues #2314 and #2321. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ef2ea60 - Browse repository at this point
Copy the full SHA ef2ea60View commit details
Commits on Jul 23, 2024
-
Uncomment setting Ca2, K, and Mg cation values passed to HETP
Previously these values were zero due to an issue in ISORROPIA. With the update to HETP we can now enable these cations. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0276c54 - Browse repository at this point
Copy the full SHA 0276c54View commit details
Commits on Jul 24, 2024
-
Merge GEOS-Chem 14.4.2 back into the 14.5.0 development stream
This merge brings the GEOS-Chem 14.4.2 release into the GEOS-Chem 14.5.0 development stream. 14.4.2 is a zero-diff update. The CHANGELOG.md has been updated accordingly. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0a17228 - Browse repository at this point
Copy the full SHA 0a17228View commit details
Commits on Jul 25, 2024
-
Merge PR #2398 (Pass non-zero Ca2, Mg, and K cations to HETP)
This merge brings PR #2398 (Pass non-zero Ca2, Mg, and K cations to HETP, by @lizziel) into the GEOS-Chem 14.5.0 development stream. This PR uncomments setting Ca2+, K+, and Mg+ cation values passed to HETP. Previously these values were zero due to an issue in ISORROPIA. With the update to HETP we can enable these cations. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e29a4c9 - Browse repository at this point
Copy the full SHA e29a4c9View commit details -
Merge 'origin/dev/14.5.0' into bugfix/alk4-chem-brewer2023
Resolved conflicts in: CHANGELOG.md KPP/fullchem/fullchem.eqn KPP/fullchem/fullchem.kpp run/shared/species_database.yml Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6548a8b - Browse repository at this point
Copy the full SHA 6548a8bView commit details
Commits on Aug 1, 2024
-
Merge PR #2352 (Fixes for ALK4 and R4N2 chemistry from J. Brewer)
This merge brings PR #2352 (Add fixes for ALK4 and R4N2 chemistry from Brewer et al. (2023, JGR), by @msulprizio) into the GEOS-Chem 14.5.0 development stream. R4N2 was a common product of alkane, isoprene, and monoterpene oxidation and produced organonitrate SOA but we don’t want ALK4 to produce organonitrate SOA as discusses in #1625. A fix from Jared Brewer is included here. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0a392d4 - Browse repository at this point
Copy the full SHA 0a392d4View commit details
Commits on Aug 5, 2024
-
PR #2352 post-merge fix: Rebuild fullchem solver files
Due to an oversight, we had forgotten to rebuild the KPP solver files for PR #2352. This has now been done. We will re-tag this PR with 14.5.0-alpha.4 to re-trigger 1-month benchmarks. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for acd3354 - Browse repository at this point
Copy the full SHA acd3354View commit details
Commits on Aug 6, 2024
-
Archive "Drydep" diags in fullchem bmks; Reduce GCHP "DryDep" output
run/GCClassic/HISTORY.rc.templates/HISTORY.rc.fullchem - Change ##'DryDep' -> #'DryDep', which will activate this collection in benchmark simulations. run/GCHP/HISTORY.rc.templates/HISTORY.rc.fullchem - Change @#'DryDep' -> #'DryDep', which will activate this collection in benchmark simulations. - Also reduce the DryDep collection species to only those species we need for benchmark plots/tables CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cb86824 - Browse repository at this point
Copy the full SHA cb86824View commit details
Commits on Aug 7, 2024
-
Fix minor issues for PR #2144 (restore drydep in benchmarks)
CHANGELOG.md - Restored missing line that was inadvertenly deleted - Place `` around "State_Chm%CH4_EMIS" run/GCHP/HISTORY.rc.templates/HISTORY.rc.fullchem - Removed extra slash in comments Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8fae654 - Browse repository at this point
Copy the full SHA 8fae654View commit details
Commits on Aug 13, 2024
-
Merge GEOS-Chem 14.4.3 back into the 14.5.0 development branch
This merge brings all of the updates from the GEOS-Chem 14.4.3 "no-diff-to-benchmark" release back into the dev/14.5.0 branch. We will test this merge with its own alpha benchmark. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 000205c - Browse repository at this point
Copy the full SHA 000205cView commit details
Commits on Aug 14, 2024
-
Add soil temperature (TSOIL1) field to State_Met for use in HEMCO soi…
…l NOx extension Yi Wang updated the soil NOx algorithm in HEMCO to utilize soil temperature as described in Yi Wang et al. (ERL, 2021). Those updates require the addition of a new meteorology field, TSOIL1, for the soil temperature in layer 1. This field has been added to State_Met. Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e4e78a7 - Browse repository at this point
Copy the full SHA e4e78a7View commit details
Commits on Aug 15, 2024
-
PR #2425 post-merge fix: Move 14.4.3 entry to top of CHANGELOG.md
CHANGELOG.md - The entry for "Tropopause pressure field..." for 14.4.3 was located much further down than it should have been. We have moved it back to to the 14.4.3 section at the top of the file. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8f0a167 - Browse repository at this point
Copy the full SHA 8f0a167View commit details -
Rebase PR #2318 (Chemistry of RCHO, HCOOH ...) to commit 8f0a167
This merge brings PR # ( , by @) into Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 99802a3 - Browse repository at this point
Copy the full SHA 99802a3View commit details -
Rebuilt the fullchem mechanism with KPP version 3.1.1
KPP/fullchem/gckpp*.F90 - GEOS-Chem "fullchem" chemistry mechanism files built with Kinetic PreProcessor version 3.1.1 KPP/custom/custom.eqn - Now consistent with KPP/fullchem/fullchem Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 32e4c09 - Browse repository at this point
Copy the full SHA 32e4c09View commit details -
Add emissions of new species to HEMCO_Config and ExtData templates
run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.fullchem run/GCHP/HEMCO_Config.rc.templates/HEMCO_Config.rc.fullchem run/GCHP/ExtData.rc.templates/ExtData.rc.fullchem - Add entries for new species (supplied by Kelvin Bates) that were introduced in the Travis et al 2023 chemistry. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7cd5aef - Browse repository at this point
Copy the full SHA 7cd5aefView commit details -
Bug fix: Remove duplicates CEDS_CH614_* containers in HEMCO_Config
run/GCClassic/HEMCO_Config.templates/HEMCO_Config.rc.fullchem run/GCHP/HEMCO_Config.templates/HEMCO_Config.rc.fullchem - Bug fix: remove duplicate set of entries for CEDS_C6H14_* sectors. These should now be added to the ALK6 species instead of ALK4. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e94b5ff - Browse repository at this point
Copy the full SHA e94b5ffView commit details -
Fixed typo in HEMCO_Config.rc.fullchem templates
run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.fullchem run/GCHP/HEMCO_Config.rc.templates/HEMCO_Config.rc.fullchem - Fix typo: "0 )))CEDSv2" -> ")))CEDSv2" Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 412f266 - Browse repository at this point
Copy the full SHA 412f266View commit details -
Update HEMCO_Config.rc for CESM with Kelvin Bates emissions updates
run/CESM/HEMCO_Config.rc - Add the corresponding updates for emissions of new species to be consistent with the GCClassic and GCHP updates Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6788b9d - Browse repository at this point
Copy the full SHA 6788b9dView commit details -
Fixed typo in species_database.yml for TLFUO2
run/shared/species_database.yml - Fixed typo: "Is_Gas:true" -> "Is_Gas: true". This causes GCPy to fail parsing the species_database.yml file. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ef63c98 - Browse repository at this point
Copy the full SHA ef63c98View commit details -
Update config files for PR #2318
run/CESM/HEMCO_Config.rc - Trim trailing whitespace run/CESM/geoschem_config.yml run/GEOS/geoschem_config.yml run/WRF/fullchem/geoschem_config.yml - Add ACR, ALK4P, ALK7, APAN, APINP, APINN, AROMPN, BPINO, BPINN, BPINP, BPINOOH, BPINON, BUTN, C96O2H, C96N, C4H6, EBZ, LIMAL, LIMKB, LIMKET, LIMN, LIMNB, LIMO2H, MEKPN, MYRCO, PHAN, PIN, PINAL, PINONIC, PINO3H, PINPAN, R7N2, R7P, RCOOH, RNO3, STYR, TMB as advected species run/GCClassic/geoschem_config.yml.templates/geoschem_config.yml - Restore ALK4P as an advected species run/GCHP/HEMCO_Diagn.rc.templates/HEMCO_Diagn.rc.fullchem - Add Emis*Total and Emis*Bioburn entries for ACR, C4H6, HCOOH, STYR - Add InvGFED* entries for ACR, C4H6, HCOOH, MVK, STYR run/GCClassic/geoschem_config.yml.templates/geoschem_config.yml.fullchem run/GCHP/geoschem_config.yml.templates/geoschem_config.yml.fullchem - Restore ALK4P as an advected species run/GCHP/HISTORY.rc.templates/HISTORY.rc - Add Emis*BioBurn entries for ACR, C4H6, HCOOH, STYR, - Add Inv*BioBurn entries for ACR, C4H6, HCOOH, STYR run/GEOS/HEMCO_Config.rc - Add new GFED species run/WRF/fullchem/HEMCO_Config.rc - Change Verbose from "0" to "false" - Add "VerboseOnCores: root" - Add new biomass burning species (from FURA onwards) - Add CEDS entries for EBZ and TMB species - Change emitted species "MACR" to "ACR" in EPA16 entries - Update CEDS scale factors as they are in GCClassic/GCHP - Remove .and. in ((( and ))) brackets and list them individually - Change "$GCAPVERTRESL" to "$GCAPVERTRES" as in GCClassic/GCHP - Add GT_Chlorine entries - Update GFED data dir to v2023-03 - Write HEMCO_Restart file in the ./Restarts folder - Now use Vohra timezones - Use v2023-10 folder for NOAA_GMD_CH4 - Add scale factors as for GCClassic and GCHP run/shared/setupConfigFiles.sh - Now insert ASOA* and ASOG* entries after species AROMPN (formerly after AROMP5) Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1958e6e - Browse repository at this point
Copy the full SHA 1958e6eView commit details -
Fix indentation in species_database.yml for aoa_PROP
run/shared/species_database.yml - Move the "aoa_PROP" back to the 1st column. It was indented erroneously when we rebased PR #2318 atop 14.5.0-alpha.4 Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8a55346 - Browse repository at this point
Copy the full SHA 8a55346View commit details
Commits on Aug 19, 2024
-
Add new species to GCHP geoschem_config.yml.fullchem template
run/GCHP/geoschem_config.yml.templates/geoschem_config.yml.fullchem - Added the species introduced by PR #2318 to the transported species list. Somehow this was either not added or lost in a merge. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d7e1248 - Browse repository at this point
Copy the full SHA d7e1248View commit details -
Merge PR #2318 (Chemistry for RCOOH, ANs, PNs)
This merge brings PR #2318 (Chemistry for RCOOH, monoterpenes, new PNs and ANs from Travis et al. (2024), by @ktravis213) into the GEOS-Chem 14.5.0 development stream. This PR introduces several new chemistry reactions following the Travis et al 2024 article. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dd7ba9a - Browse repository at this point
Copy the full SHA dd7ba9aView commit details -
PR #2318 post-merge fix: Add missing species to geoschem_config.yml
run/CESM/geoschem_config.yml run/GCClassic/geoschem_config.yml.templates/geoschem_config.yml run/GCHP/geoschem_config.yml.templates/geoschem_config.yml run/GEOS/geoschem_config.yml run/WRF/fullchem/geoschem_config.yml - Add transported species: ALK4N2, AROMCHO, HACTA, TLFUONE. These are listed as transported in species_database.yml and need to be also listed here in geoschem_config.yml. Otherwise this will cause a species mismatch in the budget diagnostics. run/shared/species_database.yml - Fix typo: "<KF2" -> "KF2" Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 53f9b2e - Browse repository at this point
Copy the full SHA 53f9b2eView commit details -
PR #2318 post-merge fix: Remove duplicate EmisHCOOH_Total entry
run/GCHP/HISTORY.rc.templates/HISTORY.rc.fullchem - Removed a duplicate entry for EmisHCOOH_Total from the Emissions collection. This was probably left over from the merge up to the dev/14.5.0 branch. Also consolidated all HCOOH emissions diagnostics together in the same block. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f240c99 - Browse repository at this point
Copy the full SHA f240c99View commit details
Commits on Aug 20, 2024
-
Add DryDepChm_O3 and DryDepMix_O3 to HISTORY.rc.fullchem
run/GCHP/HISTORY.rc.fullchem - Add the DryDepChm_O3 and DryDepMix_O3 fields to the DryDep colletction out-of-bounds error. This is to be consistent w/ GCClassic as well. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1eb36e5 - Browse repository at this point
Copy the full SHA 1eb36e5View commit details -
PR #2318 post-merge fix: Use less drydep fields for the alldiags test
run/GCHP/HISTORY.rc.templates/HISTORY.rc.fullchem - Only keep the fields that are necessary for fullchem benchmarks in the DryDep collection. This is similar to what is being done in PR #2144 (which will be merged later). Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 586260f - Browse repository at this point
Copy the full SHA 586260fView commit details -
Merge PR #2144 (Restore drydep output in fullchem benchmarks)
This merge brings PR #2144 (Restore dry deposition output in GCHP & GCClassic fullchem benchmark simulations, by @yantosca) into the GEOS-Chem 14.5.0 development stream. This PR turns on dry deposition diagnostic output in the 1-hour, 1-month, and 1-year fullchem benchmark simulations. For GCHP, we now restrict the amount of diagnostic ouptut to just what is needed to make the benchmark plots. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c7332ed - Browse repository at this point
Copy the full SHA c7332edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 443a91a - Browse repository at this point
Copy the full SHA 443a91aView commit details
Commits on Aug 21, 2024
-
Add UseSoilTemperature option to SoilNOx extension in HEMCO_Config.rc…
… and read TSOIL1 when activated A new option UseSoilTemperature has been added to the SoilNOx extension section in HEMCO_Config.rc. Entries for TSOIL1 have been added to HEMCO_Config.rc.gmao_fields (GCClassic) and ExtData.rc.fullchem (GCHP). The field should only be read in GCClassic if the option UseSoilTemperature - now renamed without spaces for use in HEMCO logical brackets - is set to true. Additionally, a new Input_Opt%UseSoilTemp logical is now initialized in hco_interface_mod.F90 and used in flexgrid_read_mod.F90 to only obtain TSOIL1 when UseSoilTemperature is true in HEMCO. For GCHP, the TSOIL1 line will need to be manually edited for now. Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0aaee51 - Browse repository at this point
Copy the full SHA 0aaee51View commit details -
Merge branch 'origin/dev/14.5.0' into feature/ywang_soil_nox
Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a8e1983 - Browse repository at this point
Copy the full SHA a8e1983View commit details -
Update GFED4_Climatology entries for period 2010-2023
run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.aerosol run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.fullchem run/GCHP/HEMCO_Config.rc.templates/HEMCO_Config.rc.fullchem - Edit GFED4_Climatology files so that they point to the new climatology file for 2010-2023 generated from a HEMCO 3.10.0 standalone simulation CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0620a7e - Browse repository at this point
Copy the full SHA 0620a7eView commit details
Commits on Aug 26, 2024
-
Merge PR #2428 (Fix mass non-conservation in VDIFF)
This merge brings PR #2428 (Fix mass non-conservation in VDIFF PBL mixing, by @nicholasbalasus) into the GEOS-Chem 14.5.0 development stream. This PR fixes a mass conservation bug in the VDIFF PBL mixing that especially affected long-lived species (like CH4, CO2, etc.). Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3073aff - Browse repository at this point
Copy the full SHA 3073affView commit details -
Store optical properties *.dat files in new data directory
These files include so4.dat etc which are read by subroutine Rd_AOD. The new data directory is specified in the aerosol menu of geoschem_config.yml. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bb2cc85 - Browse repository at this point
Copy the full SHA bb2cc85View commit details -
Move RD_AOD and CALC_AOD from photolysis module to aerosols module
These subroutines must be called even if photolysis is off since they are used for aerosol optical depths. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 388db30 - Browse repository at this point
Copy the full SHA 388db30View commit details -
Call RD_AOD and CALC_AOD within Init_Aerosol subroutine
Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a436582 - Browse repository at this point
Copy the full SHA a436582View commit details -
Configuration menu - View commit details
-
Copy full SHA for c746667 - Browse repository at this point
Copy the full SHA c746667View commit details -
Also call RD_AOD and CALC_AOD in Fast-JX initialization for Hg simula…
…tion Fast-JX, unlike Cloud-J, uses arrays set in CALC_AOD. Since the Hg simulation uses Fast-JX and does not trigger calling Init_Aerosol we need to call RD_AOD and CALC_AOD during Fast-JX initialization. The Hg simulation is the only simulation that uses Fast-JX and it will be deleted in the future once offline aerosol wet concentration files are available for Cloud-J. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 303caa2 - Browse repository at this point
Copy the full SHA 303caa2View commit details -
Update criteria for calling Init_Aerosol to be based on simulation type
Previously Init_Aerosol was initialized based on various aerosol logicals. A more robust method is to always call Init_Aerosol for the full chemistry and aerosol-only simulations. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0c1ab5e - Browse repository at this point
Copy the full SHA 0c1ab5eView commit details -
Remove RD_AOD and CALC_AOD from photolysis_mod
Somehow these subroutines were not previously removed. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 99bfba4 - Browse repository at this point
Copy the full SHA 99bfba4View commit details -
Add aerosol optics input dir to geoschem_config.yml.Hg template
run/GCClassic/geoschem_config.yml.templates/geoschem_config.yml.Hg - Add the the aerosols:optics:input_dir YAML tags to specify the location of the aerosol optics folder. This had been omitted, and was causing the Hg simulation to fail with a file-not-found error. Now fixed. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 75d885d - Browse repository at this point
Copy the full SHA 75d885dView commit details
Commits on Aug 27, 2024
-
Add missing entries for TMB and OTHER_VOC in ExtData.rc.fullchem
run/GCHP/ExtData.rc.templates/ExtData.rc.fullchem - Added missing entries for CEDS_TMB_SHP and CEDS_OTH_SHP Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e3d3f9b - Browse repository at this point
Copy the full SHA e3d3f9bView commit details
Commits on Aug 28, 2024
-
Initial update for PPN photolysis from Horner et al 2024
Headers/CMN_FJX_MOD.F90 - Change JVN from 166 to 167 KPP/fullchem/fullchem.eqn KPP/custom/custom.eqn - Added rxns for PPN KPP/fullchem/CHANGELOG_fullchem.md - Added description of updates Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7919ccd - Browse repository at this point
Copy the full SHA 7919ccdView commit details -
Rebuild chemical mechanism for PPN photolysis w/ KPP 3.1.1
KPP/fullchem/gckpp*F90 - Rebuilt with KPP 3.1.1 CHANGELOG.md KPP/fullchem/CHANGELOG_fullchem.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 99f1cf9 - Browse repository at this point
Copy the full SHA 99f1cf9View commit details -
Update run scripts and environment files for NASA discover cluster
Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 113f634 - Browse repository at this point
Copy the full SHA 113f634View commit details
Commits on Aug 29, 2024
-
Merge PR #2371 (Adding PPN photolysis)
This merge brings PR #2371 (Adding PPN photolysis, by @bexhorner) into the GEOS-Chem 14.5.0 development stream. This PR adds photolysis rxns for the PPN species. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 43d0e90 - Browse repository at this point
Copy the full SHA 43d0e90View commit details -
Merge PR #2439 (Update run scripts and env files for Discover)
This merge brings PR #2439 (Update run scripts and environment files for NASA discover cluster, by @lizziel) into the GEOS-Chem 14.5.0 development stream. This PR updates the operational run scripts and environment files for using GC-Classic and GCHP on the NASA discover cluster. This includes environment files using both GNU and Intel fortran compiler on Milan nodes. GEOS-Chem CTM users on discover can easily access these files in GEOS-Chem run directories starting in version 14.5.0 via symlink runScriptSamples/operational_examples/nasa_discover. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d4c47ba - Browse repository at this point
Copy the full SHA d4c47baView commit details -
Bug fix: Replace $YYYY with %y4 in ExtData.rc.fullchem
run/GCHP/ExtData.rc.templates/ExtData.rc.fullchem - Replaced $YYYY (which is the HEMCO_Config.rc token) with %y4, which is the MAPL token in the OTHER_VOC_shp container. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 211c6dc - Browse repository at this point
Copy the full SHA 211c6dcView commit details -
Merge PR #2436 (Update GFED4 climatology for 2010-2023)
This merge brings PR # (Update GFED4_Climatology entries for period 2010-2023 with new species, by @yantosca) into the GEOS-Chem 14.5.0 development stream. This is the companion PR to issue #2415. We have re-generated the GFED4 climatology and GFED4 monthly mean data files by running the HEMCO standalone simulation for the period 2010-2023. We have also included the new species that were introduced in PR #2318 and HEMCO PR https://github.com/geoschem//HEMCO#285. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d34c567 - Browse repository at this point
Copy the full SHA d34c567View commit details -
PR #2436 post-merge update: Fix typo in ExtData.rc.fullchem
run/GCHP/ExtData.rc.templates/ExtData.rc.fullchem - Fixed typo in CEDS_TMB_SHP entry, the file specified was HCOOH-em-anthro_CMIP_CEDS_%y4.nc but should have been TMB-em-anthro_CMIP_CEDS_%y4.nc. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 602b660 - Browse repository at this point
Copy the full SHA 602b660View commit details -
Expand photolysis menu to set Cloud-J options at run-time
Besides options previously in input file CJ77.dat, there is now the option to turn off the UV absorption by water vapor. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e0ba09e - Browse repository at this point
Copy the full SHA e0ba09eView commit details -
Compute water concentration to pass to Cloud-J for UV absorption by H2O
The concentration is computes from species concentration is H2O is a species. Otherwise it is computed from the specific humidity in the input meteorology. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d89087d - Browse repository at this point
Copy the full SHA d89087dView commit details -
Pass spherical correction from parent model rather than hard-code
This update also moves all Cloud-J parameters set in geoschem_config.yml to new sub-menu called cloud-j within the photolysis menu. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d304ba7 - Browse repository at this point
Copy the full SHA d304ba7View commit details -
Signed-off-by: Lizzie Lundgren <[email protected]> # Conflicts: # CHANGELOG.md
Configuration menu - View commit details
-
Copy full SHA for 810228b - Browse repository at this point
Copy the full SHA 810228bView commit details -
Update Cloud-J data directory paths for Cloud-J v8 input files
Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f839a16 - Browse repository at this point
Copy the full SHA f839a16View commit details -
Merge PR #2426 (Store aerosol-specific optics files in new directory)
This merge brings PR #2426 (Store aerosol-specific optics files in new Aerosol_Optics data directory, by @lizziel) into the GEOS-Chem 14.5.0\ development stream. This PR moves the aerosol-specific optics data files (so4.dat, dust.dat, etc) into a new data directory with path specified in the Aerosols menu in geoschem_config.yml. Previously these files were stored in the same data directory as photolysis input files. However, since we now have both FAST-JX (for Hg simulation) and Cloud-J (for fullchem and aerosol sims) we would need to store identical files in two different places. This is not ideal. In addition it may cause confusion since these files are no longer used for photolysis in Cloud-J. Aerosol optical properties used in Cloud-J come from input file FJX_scat-aer.dat. There are a few additional changes in this PR related to this data: 1. Move the calls to RD_AOD and CALC_AOD from Init_Photolysis to both Init_Aerosol and Init_FastJX. The former is for use in full chemistry and aerosol-only simulations. The latter is for use in the Hg simulation since it still uses Fast-JX and Fast-JX uses arrays computed by CALC_AOD. 2. Change the criteria to call Init_Aerosol to be based on simulation type rather than Input_Opt logicals for different aerosols. Init_Aerosol is now always called if using the full chemistry or aerosol-only simulation. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 647c9f5 - Browse repository at this point
Copy the full SHA 647c9f5View commit details -
Merge PR #2424 (Support for Cloud-J_v8.0.0)
This merge brings PR #2424 (Support for Cloud-J_v8.0.0, by @lizziel) into the GEOS-Chem 14.5.0 development stream. This pull request brings in updates for compatibility with Cloud-J version 8.0.0. The primary change is expanding the photolysis menu in configuration file geoschem_config.yml to allow easy run-time configuration of Cloud-J from GEOS-Chem run directories. Previously these settings were configured in an input file stored in external data directories. Also in this update is the inclusion of the option to turn off the UV absorption by water vapor. H2O UV absorption is the main update in Cloud-J v8 and some GEOS-Chem users may want to experiment with it. It is turned on by default but can be toggled off in the photolysis menu of geoschem_config.yml. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 40a0785 - Browse repository at this point
Copy the full SHA 40a0785View commit details
Commits on Sep 3, 2024
-
Hotfix: Declare PPN as photolyzing in the species database
run/shared/species_database.yml - Add "Is_Photolysis: true" YAML tag for PPN. We had omitted this from PR #2371. CHANGELOG.md - Updated accordingly. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1951ea9 - Browse repository at this point
Copy the full SHA 1951ea9View commit details -
Merge branch 'dev/14.5.0' into feature/ywang_soil_nox
Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d13c4fa - Browse repository at this point
Copy the full SHA d13c4faView commit details
Commits on Sep 5, 2024
-
Bug fix: Properly order photo rxns for PPN, PNs, and ANs
KPP/fullchem/fullchem.eqn KPP/custom/custom.eqn - Update comments - Reorder the photolysis reactions to use the proper slots of the PHOTOL array. This now matches the order in FJX_j2j.dat. - PPN : 167 - APINP : 168 - PINAL : 169 - PINO3H : 170 - PINONIC : 171 - C96O2H : 172 - BPINP : 173 - BPINOOH : 174 - LIMO3H : 175 - LIMO2H : 176 - LIMAL : 177 KPP/fullchem/gckpp*.F90 - Rebuilt with KPP 3.1.1 CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0332049 - Browse repository at this point
Copy the full SHA 0332049View commit details
Commits on Sep 6, 2024
-
Merge PR #2452 (Reorder photo rxns for PNs and ANs)
This merge brings PR # (Bug fix: Reorder photo rxns for PNs and ANs (from PR #2318), by @yantosca) into the GEOS-Chem 14.5.0 development stream. This PR reorders the photo rxns that were added in PR #2318 so that they now follow PPN as listed in Cloud-J config file FJX_j2j.dat. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a5fba9c - Browse repository at this point
Copy the full SHA a5fba9cView commit details
Commits on Sep 11, 2024
-
Fix entries with "Is_Photolysis: true" in species_database.yml
run/shared/species_database.yml - Added "Is_Photolysis: true" to the following entries: APINP, AROMCHO, BPINOOH, BPINP, C96O2H, H2O, HO2, LIMAL, LIMO2H, LIMO3H, PINAL, PINO3H, PINONIC, SO2 - Removed "Is_Photolysis: true" from the following entries: APINN, AROMPN, BPINN, BPINON, C96N, CHCl3, HC5A, LIMN, LIMNB, LIMPAN, MEKPN, MPAN, PHAN, PIN, PINPAN - Moved PINO3H to be in alphabetical order. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7c73070 - Browse repository at this point
Copy the full SHA 7c73070View commit details
Commits on Sep 12, 2024
-
Updated J-value entries in GCHP HISTORY.rc.fullchem file
run/GCHP/HISTORY.rc.templates/HISTORY.rc.fullchem - Updated "Jval_" entries to use only the proper photolysis species CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 25332d3 - Browse repository at this point
Copy the full SHA 25332d3View commit details -
Updated note in CHANGELOG.md about added species
CHANGELOG.md - Consolidate species that were added in Travis et al 2024 into a single note under "Added" Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7361083 - Browse repository at this point
Copy the full SHA 7361083View commit details
Commits on Sep 13, 2024
-
Merge PR #2457 (Update Is_Photolysis tags in species_database.yml)
This merge brings PR #2457 (Update Is_Photolysis tags in species_database.yml to be consistent with Cloud-J file FJX_j2j.dat, by @yantosca) into the GEOS-Chem 14.5.0 development stream. This PR now ensures that all species that are listed as photolyzing in the KPP fullchem.eqn file and the FJX_j2j.dat file have "Is_Photolysis: true" tags in run/shared/species_database.yml. The "Is_Photolysis: true" tags were also removed from species that are not photolyzing. Also, the JValues collection was updated in run/GCHP/HISTORY.rc.templates/HISTORY.rc.fullchem accordingly. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cd03660 - Browse repository at this point
Copy the full SHA cd03660View commit details -
Bug fix: ALK6 in HEMCO_Config.rc should be ALK7
With the updated monoterpene/PN/AN chemistry and emissions added in 14.5.0-alpha.6 (updates on top of PR #2318), emissions for >=C6 alkanes from CEDS were added to HEMCO_Config.rc. These were incorrectly assigned to species ALK6 (not defined) when they should be assigned to ALK7. Other fixes here include: - Update HEMCO_Diagn.rc (and HISTORY.rc for GCHP) to save out ALK7 emissions - Fix category for CEDS ship emissions of HCOOH and ALK7 in HEMCO_Config.rc (should be 10, not 1) - Make fullchem HEMCO_Diagn.rc for WRF consistent with GCClassic version Closes #2459 Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 84da437 - Browse repository at this point
Copy the full SHA 84da437View commit details -
Merge PR #2430 (Updated Y. Wang soil NOx scheme as an option)
This merge brings PR #2430 (Updated soil NOx scheme from Yi Wang et al. (2021) as an option, by @msulprizio) into the GEOS-Chem 14.5.0 development stream. This PR updates source code and configuration files to activate the new soil NOx scheme by Yi Wang et al. 2021. This must be merged along with HEMCO PR #287. This will be a zero-diff update w/r/t benchmarks, as this option will be disabled by default until the TSOIL met archive has been generated. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for aa40c69 - Browse repository at this point
Copy the full SHA aa40c69View commit details
Commits on Sep 16, 2024
-
Merge PR #2430 (Updated Y. Wang soil NOx scheme as an option)
This merge brings PR #2430 (Updated soil NOx scheme from Yi Wang et al. (2021) as an option, by @msulprizio) into the GEOS-Chem 14.5.0 development stream. This PR updates source code and configuration files to activate the new soil NOx scheme by Yi Wang et al. 2021. This must be merged along with HEMCO PR #287. This will be a zero-diff update w/r/t benchmarks, as this option will be disabled by default until the TSOIL met archive has been generated. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5c31c34 - Browse repository at this point
Copy the full SHA 5c31c34View commit details -
Merge PR #2462 (Bug fix: ALK6 in HEMCO_Config.rc should be ALK7)
This merge brings PR #2462 (Bug fix: ALK6 in HEMCO_Config.rc should be ALK7, by @msulprizio) into the GEOS-Chem 14.5.0 development stream. This PR fixes a bug introduced in PR #2318, where the ALK7 species was erroneously named ALK6 in HEMCO configuration files. Signed-off-by: Bob Yantosca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c0aeff4 - Browse repository at this point
Copy the full SHA c0aeff4View commit details
Commits on Sep 17, 2024
-
Add seasonality to CH4 reservoir emissions
Previously reservoir emissions from the ResME inventory were included every month but there should be none during the cold months. From Delwiche et al. (2022): Since individual reservoir modeling for stratification is beyond the scope of ResME, we instead provide degassing estimates for two potential scenarios: (a) maximum possible degassing if reservoirs were stratified year-round and thus T b = (0.5 + Bubdiss) x P in each month, and (b) reservoir is stratified for the 2 months before and after peak reservoir temperature (5 months total), with monthly degassing zero otherwise. To apply seasonality to the ResME emissions, a monthly mask file has been created to zero emissions above 30N and below 30S outside of the 5 warmest months for that hemisphere. Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c66e775 - Browse repository at this point
Copy the full SHA c66e775View commit details -
Remove Is_Photolysis in species database for species not in FJX_j2j.dat
This update is for full chemistry only. J-value diagnostics are only populated with non-zero values for species in FJX_j2j.dat. Other species that have Is_Photolysis=True have J-value diagnostics created but are filled with all zeros. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 53a0ed5 - Browse repository at this point
Copy the full SHA 53a0ed5View commit details -
Remove Is_Photolysis in species database for species not in fullchem.eqn
Species H2O and SO2 have J-values computed which are not used in the full chemistry simulation. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5ea40b2 - Browse repository at this point
Copy the full SHA 5ea40b2View commit details
Commits on Sep 19, 2024
-
Update CH4 emissions in ExtData.rc to convert molec/cm2/s to kg/m2/s
The data in molec/cm2/s is converted to kg/m2/s automatically if reading data in through HEMCO. Since GCHP does not use HEMCO for data read we need to instead specify a scaling factor in a configuration file. This update fixes a bug in GCHP carbon simulations where CH4 emissions were applied in the wrong units. This commit also fixes a bug where several ExtData.rc entries for gridded GHGI v2 Express Extension emissions were specified as monthly when they are actually annual. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e270831 - Browse repository at this point
Copy the full SHA e270831View commit details -
Update dry mass ratio of seasalt in aerosol thermodynamics
This commit includes two updates submitted by Yuk Chun Chan (UW) and Becky Alexander (UW): 1. From Yuk Chun Chan: "To account for the missing Ca, Mg, and K, the Na-to-seasalt mass ratio was artificially increased from 0.3061 (i.e., seawater average) to 0.397 in previous versions. Since we are re-introducing Ca, Mg, and K to the model now, we should adjust the Na-to-SS mass ratio from 0.397 back to 0.3061. Otherwise, we would get excess amount of cations in the model." 2. From Becky Alexander: The TNA equation needs "to be changed, which deals with coarse-mode sea salt aerosol. The current value is 0.378. I don't know why these values are different for fine and coarse mode. They should both be 0.3061, which is the dry mass fraction of sea salt." Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ef2b073 - Browse repository at this point
Copy the full SHA ef2b073View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd8cce6 - Browse repository at this point
Copy the full SHA dd8cce6View commit details
Commits on Sep 20, 2024
-
Merge PR #2467 containing fixes for dry mass fraction of seasalt in a…
…erosol thermodynamics Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 875a159 - Browse repository at this point
Copy the full SHA 875a159View commit details
Commits on Sep 24, 2024
-
Bugfix: Restore stale workflow functionality
The stale workflows are currently failing with the error: Invalid workflow file: .github/workflows/stale.yml#L26 The workflow is not valid. .github/workflows/stale.yml (Line: 26, Col: 11): A sequence was not expected To fix this, the list of exempt-issues-labels in .github/workflows/stale.yml must be a comma separated list. A single quote is placed around the list to allow for use of colons in label names. Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2345214 - Browse repository at this point
Copy the full SHA 2345214View commit details -
Merge branch 'dev/14.5.0' into feature/ch4-seasonal-reservoir
# Conflicts: # CHANGELOG.md
Configuration menu - View commit details
-
Copy full SHA for 1e87827 - Browse repository at this point
Copy the full SHA 1e87827View commit details
Commits on Sep 25, 2024
-
Fix entry for SEASONAL_RES_MASK in ExtData.rc.carbon for GCHP
@lizziel wrote: Change 'N' to 'Y' (climatology column) and 'F%y2-%m2' to 'F2022-%m2' (year of climatology in file). Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7238aac - Browse repository at this point
Copy the full SHA 7238aacView commit details -
Bug fix for double counting CH4 agricultural burning emissions
In the carbon and CH4 simulations, agricultural burning emissions were double counted between EDGAR v8 (AWB sector) and GFED4. To avoid this, we comment out the EDGAR8_CH4_AWB entries in HEMCO_Config.rc. This addresses issue #2476. Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 95827cc - Browse repository at this point
Copy the full SHA 95827ccView commit details
Commits on Sep 27, 2024
-
Fix typo in SEASONAL_RES_MASK entry in ExtData.rc.carbon
Removed an extra dash after the time token which was causing the ExtData in MAPL to crash with the error "ERROR: File template Mask has invalid reference date format." Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f2f6e09 - Browse repository at this point
Copy the full SHA f2f6e09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 580c4e0 - Browse repository at this point
Copy the full SHA 580c4e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f11ef0 - Browse repository at this point
Copy the full SHA 4f11ef0View commit details -
Merge PR #2472 containing a fix for the stale issue Github workflow
Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7ffdb5b - Browse repository at this point
Copy the full SHA 7ffdb5bView commit details
Commits on Sep 30, 2024
-
Update formulas for TK, TMg, and TCa
Fix the bug of using SALA mass to compute coarse-mode TK, TMg, and TCa. Add AlkR factor to the formulas.
Configuration menu - View commit details
-
Copy full SHA for e3113b3 - Browse repository at this point
Copy the full SHA e3113b3View commit details -
Clean up CHANGELOG.md for 14.5.0 release
The entries for 14.5.0 (unreleased) have been updated to: - remove duplicate entries - consistently start lines with past-tense verbs - remove items listing fixes on updates added in this version Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cf3f81b - Browse repository at this point
Copy the full SHA cf3f81bView commit details -
Update the description for recent changes related to Ca, K, Mg, and Na in aerosol_thermodynamics_mod.F90
Configuration menu - View commit details
-
Copy full SHA for 6aa3ca2 - Browse repository at this point
Copy the full SHA 6aa3ca2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ced6447 - Browse repository at this point
Copy the full SHA ced6447View commit details
Commits on Oct 1, 2024
-
Merge PR #2490 cleaning up CHANGELOG.md
Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c7a6ae6 - Browse repository at this point
Copy the full SHA c7a6ae6View commit details -
Fix GCHP ExtData.rc entry for CO2 diurnal scale factors
Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f8d21f2 - Browse repository at this point
Copy the full SHA f8d21f2View commit details -
Use ALK6 species name for >= C6 alkanes instead of ALK7
For consistency with the literature (e.g. Travis et al, EGUsphere, 2024) we rename ALK7 to ALK6. See further discussion in Github issue #2459. Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 341ac16 - Browse repository at this point
Copy the full SHA 341ac16View commit details
Commits on Oct 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 57cf0df - Browse repository at this point
Copy the full SHA 57cf0dfView commit details -
Merge PR #2492 with fixes for the GCHP carbon simulation
Signed-off-by: Melissa Sulprizio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 51d306d - Browse repository at this point
Copy the full SHA 51d306dView commit details
Commits on Oct 4, 2024
-
Fix bug in Chem_ORVCsesq restart file entry in GC-Classic fullchem co…
…nfig Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0c2877a - Browse repository at this point
Copy the full SHA 0c2877aView commit details -
Change state_met diagnostic output to be same precision as in the model
For most cases this is double precision. Previously State_Met arrays were always saved out as single. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9a06d08 - Browse repository at this point
Copy the full SHA 9a06d08View commit details -
Fix minor error in checking variables after State_Chm array allocation
Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f6057f1 - Browse repository at this point
Copy the full SHA f6057f1View commit details -
Change state_chm diagnostic output to be same precision as in model
This is FP for all cases except STATE_PSC which is real4 and DryDepVel which is always real8. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0e3b60d - Browse repository at this point
Copy the full SHA 0e3b60dView commit details -
Write out restart species concentrations as REAL8
Previously these were written as REAL4 despite being stored in the model as REAL8. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5196db6 - Browse repository at this point
Copy the full SHA 5196db6View commit details -
Remove unused local variables in ucx_mod
Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6bcd1d9 - Browse repository at this point
Copy the full SHA 6bcd1d9View commit details -
Move getting restart var DELPDRY to subroutine GC_Get_Restart
This is a no diff update but now allows print of min, max, sum of restart variable Met_DELPDRY to be included with all of the other restart variables retrieved from HEMCO into GEOS-Chem. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 97fbe1b - Browse repository at this point
Copy the full SHA 97fbe1bView commit details
Commits on Oct 15, 2024
-
Add GeosUtil/print_mod.F90 for specialized model print options
This module currently has one subroutine only, to print min, max, and mean of species concentrations to log. It currently only prints if root thread and does not convert units. Optional arguments allow printing one species or a consecutive sequence of species indexes. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3a65c4f - Browse repository at this point
Copy the full SHA 3a65c4fView commit details -
Convert species concentration units of mol/mol <-> kg/kg in main.F90
This update ensures error is not introduced due to unit conversions used for saving species to the restart file in mol/mol. Conversion to mol/mol must occur every timestep as part of updating diagnostics used for restart variables so that GEOS-Chem Classic can achieve bit-for-bit reproducibility upon breaking up runs. We still use kg/kg dry air throughout main.F90. Conversion from mol/mol to kg/kg occurs at the start of every timestep. This also means that mol/mol is not converted to kg/kg in the subroutine that retrieves restart variables from HEMCO during initialization since it will occur later. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 011e80c - Browse repository at this point
Copy the full SHA 011e80cView commit details -
Move setting prescribed CH4 to just after emissions
It is necessary to move where prescribed CH4 is set because it is dependent on PBL height and previously PBL height was not updated until after Set_CH4 was called. This introduces small differences in GC-Classic when breaking up runs. CH4 is now set using updated PBL height and is grouped with emissions where other prescribed surface VMRs are applied. It is still applied outside of emissions. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c9df854 - Browse repository at this point
Copy the full SHA c9df854View commit details
Commits on Oct 16, 2024
-
Fix parallelization issue called SOIL_DRYDEP from HEMCO interface
Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6d3db18 - Browse repository at this point
Copy the full SHA 6d3db18View commit details -
Clean up string formating in Get_GC_Restart subroutine
Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1280b19 - Browse repository at this point
Copy the full SHA 1280b19View commit details
Commits on Oct 17, 2024
-
No diff fixes to SOIL_WETDEP and SOIL_DRYDEP
This commit removes the level argument since it is not actually used in the subroutines. This update also uncomments a Soil NOx extension logical bracketed around a call to SOIL_WETDEP. The subroutine only changes arrays used in Soil NOx extension so calling it when the extension is off is not necessary. Signed-off-by: Lizzie Lundgren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c0aa7f7 - Browse repository at this point
Copy the full SHA c0aa7f7View commit details