Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special type for scanning of unused columns (V1) (#132) #134

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

georgysavva
Copy link
Owner

  • add noOpScanType

  • remove Value method

  • add test for scanning of unknown enum

  • fix tests

  • update db version

  • fix codecov

  • use token in codecov


* add noOpScanType

* remove Value method

* add test for scanning of unknown enum

* fix tests

* update db version

* fix codecov

* use token in codecov

---------

Co-authored-by: Georgy Savva <[email protected]>
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.76%. Comparing base (d706b62) to head (c33203b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   81.02%   80.76%   -0.27%     
==========================================
  Files           5        5              
  Lines         564      473      -91     
==========================================
- Hits          457      382      -75     
+ Misses         92       76      -16     
  Partials       15       15              
Flag Coverage Δ
unittests 80.76% <100.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgysavva georgysavva merged commit e49daf9 into master Apr 7, 2024
5 checks passed
@georgysavva georgysavva deleted the unused-column-fix-from-v1 branch April 7, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants