updated the main config #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminye
reviewed
Apr 3, 2024
| test_suite = LLMTestSuite(tests, prompts, ground_truths, model_preds) | ||
| # TODO: Save Unit Test Results | ||
| test_suite.save_test_results('unit_test_results.csv') | ||
| pass |
benjaminye
approved these changes
Apr 3, 2024
benjaminye
requested changes
Apr 3, 2024
There was a problem hiding this comment.
@VivekSinghDS, there has been a bit of change in the repo. See PR #118. We have migrated toolkit.py from the parent directory into llmtune/cli/toolkit.py. You need to copy your changes in that file -- really sorry for the inconvenience.
To test your code, you just need to run (in a virtual environment) pip install -e . and do llmtune [--config-path <your_config_path>] where stuff in [ ] are optional.
In addition, we have adopted ruff as our linter and formatter. Please pip install ruff and run these before PR:
ruff check --fixruff format
truskovskiyk
reviewed
Apr 3, 2024
| # TODO: Run Unit Tests | ||
| test_suite = LLMTestSuite(tests, prompts, ground_truths, model_preds) | ||
| # TODO: Save Unit Test Results | ||
| test_suite.save_test_results('unit_test_results.csv') |
There was a problem hiding this comment.
could we remove hardcode here?
Merged
|
Closed as it is superseded by #131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.