Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not quite certain whether we should be using
OsPath
orPosixPath
. Thefilepath
library could perhaps be clearer about the distinction. I think the latter is preferable since this is a Linux-specific library. And I kind of have to use it anyway due tounix
(seeopenFd
).But then
doesFileExist
andlistDirectory
wantOsPath
, hence the conversions here via internal constructors. I think, looking at thefile-io
library, the intention is that utilities are duplicated forOsPath
andPlatformPath
, and the problem is maybe just thatdirectory
doesn't have the latter for some reason.We also still have
fsnotify
, which still uses plain old strings, but will presumably eventually switch to usingOsPath
notPosixPath
since, unlike us, it's cross-platform...