Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set header to config file #726

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set header to config file #726

wants to merge 1 commit into from

Conversation

f-necas
Copy link
Contributor

@f-necas f-necas commented Dec 23, 2024

No description provided.

@landryb
Copy link
Member

landryb commented Dec 26, 2024

i had a closer look, and you drop the IgnoreIFrame param bit that was added in #155, im not fully sure to understand what it was supposed to achieve.. my guess would be embedding a context as a iframe in a page shouldn't include the header, be it as the legacy header iframe, or the newer web-component header ? in that case, is this behaviour preserved ?

I havent found other occurences in the code besides tests (https://github.com/search?q=repo%3Ageorchestra%2Fmapstore2-georchestra%20ignoreIFrame&type=code) so i'm .. puzzled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants