-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#714: Project update to the latest MapStore 2024.02 #715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the issues found
Verified issues
- Restructuring of Login and Home in Dashboard page has not been applied. Login should not be added, but the sidebar is missing.
- Adding spatial filter to dashboard widgets I don't see the changes in localConfig.json for this. I was not able to verify, becasue I'm not being able to login.
Not verified
- I wasn't able to test login with usual test_env. So I'm not sure if user integration works. As far as I can see, there no simple way to test it. Maybe intalling georchestra locally with docker.
- Maven project update not done, does ntot make the application break, but maybe it is better to do this update for future work.
- As well as the login, I wasn't able to verify if print still works. Let's wait deploy in test for this.
Points to make notice to the client
From migration guidelines.
- Enable showing credits/attribution text in Print config and Print config file update can be important, because they should have customized their print template.
- Using elevation layer type instead of wms layer with useForElevation property. May require a manual update of contexts from UI, if 3D is used.
- Database update this should work, but they have to make sure on their customization properties files if they didn't set this option to validate. This has been highlighted by @dsuren1 in PR description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed duplicated spring security issues and other issues with missing copied files.
Needs to be tested in dev environment for ldap connection .
better to avoid forced exclusions imo and use the mapstore-services SNAPSHOT which has the spring sec fix. In 2 weeks we will release the next minor version so I don't think it is a big deal to use a stable SNAPSHOT for now considering also we are doing this on master branch here :-) |
Description
This PR updates the MS submodules to
2024.02.xx
and aligns the configuration while preserving project specific configsIssue
Note
An empty
favicon.ico
file has been added to prevent build failures caused by an invalid path. Based on this PR, assuming the script will replace the favicon path, no further action is requiredDB Changes
Follow the migration details with respect to DB/schema changes:
In detail migration information is available here
POSTGRESQL
ORACLE
H2