Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#645 & #681: Fix - Annotations circle geometry #685

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

dsuren1
Copy link
Collaborator

@dsuren1 dsuren1 commented Dec 20, 2023

@landryb
Copy link
Member

landryb commented Jan 2, 2024

fwiw, i see that in upstream mapstore2 by default COG support was hidden (@tdipisa you think its 'experimental' apparently?), and from my understanding this PR will disable it this via geosolutions-it/MapStore2#9699

how will it affect the availability of the COG feature in ms2-georchestra ?

should it be reenabled by modifying localConfig.json and adding it back to the MetadataExplorer plugin config as done in geosolutions-it/MapStore2@57e3013 ?

if so, could that PR also take care of this ?

(on a sidenote, i welcome updating the submodule to gain all the fixes that landed in the 2023.02.xx branch)

@dsuren1
Copy link
Collaborator Author

dsuren1 commented Jan 8, 2024

@landryb Updated the config

Copy link
Collaborator

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdipisa tdipisa merged commit 5708084 into georchestra:master Jan 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants