Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Annotations] Disabled annotations are printed #646

Closed
catmorales opened this issue Aug 23, 2023 · 2 comments · Fixed by geosolutions-it/MapStore2#9837, #691 or #694
Closed

[Annotations] Disabled annotations are printed #646

catmorales opened this issue Aug 23, 2023 · 2 comments · Fixed by geosolutions-it/MapStore2#9837, #691 or #694
Assignees
Labels
Accepted bug Something isn't working

Comments

@catmorales
Copy link
Collaborator

Describe the bug
If several annotations exist in the "Annotations" layer, the annotations whose visibility is disabled are still printed and visible in the PDF generated by MapfishPrint.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
print_disabled _annotation
json file :

{
    "features": [{
            "type": "FeatureCollection",
            "properties": {
                "id": "4e140700-402f-11ee-a6e0-670ce0e57c93",
                "title": "visible",
                "visibility": true
            },
            "features": [{
                    "type": "Feature",
                    "geometry": {
                        "coordinates": [[[-1.7510546105248588, 48.00719092864499], [-1.7504260476146425, 48.00491186587863], [-1.748844502227647, 48.00504752719536], [-1.7497974847044264, 48.00725875635083], [-1.7510546105248588, 48.00719092864499]]],
                        "type": "Polygon"
                    },
                    "properties": {
                        "id": "4fe54490-402f-11ee-a6e0-670ce0e57c93",
                        "isValidFeature": true,
                        "canEdit": false
                    },
                    "style": [{
                            "color": "#ffcc33",
                            "opacity": 1,
                            "weight": 3,
                            "fillColor": "#7ed321",
                            "fillOpacity": 1,
                            "editing": {
                                "fill": 1
                            },
                            "highlight": false,
                            "id": "4fe4cf60-402f-11ee-a6e0-670ce0e57c93"
                        }
                    ]
                }
            ],
            "style": {
                "highlight": false
            }
        }, {
            "type": "FeatureCollection",
            "properties": {
                "id": "667617c0-402f-11ee-a6e0-670ce0e57c93",
                "title": "invisible",
                "visibility": false
            },
            "features": [{
                    "type": "Feature",
                    "geometry": {
                        "coordinates": [[[-1.7491486455713, 48.00725875635083], [-1.74813483442579, 48.005128923814134], [-1.7467966037137166, 48.005305282714154], [-1.7481753868716103, 48.007367280494634], [-1.7491486455713, 48.00725875635083]]],
                        "type": "Polygon"
                    },
                    "properties": {
                        "id": "67e49be0-402f-11ee-a6e0-670ce0e57c93",
                        "isValidFeature": true,
                        "canEdit": false
                    },
                    "style": [{
                            "color": "#ffcc33",
                            "opacity": 1,
                            "weight": 3,
                            "fillColor": "#d0021b",
                            "fillOpacity": 1,
                            "editing": {
                                "fill": 1
                            },
                            "highlight": false,
                            "id": "67e44dc0-402f-11ee-a6e0-670ce0e57c93"
                        }
                    ]
                }
            ],
            "style": {
                "highlight": false
            }
        }
    ],
    "type": "ms2-annotations"
}

Desktop (please complete the following information):
tested on https://portail-test.sig.rennesmetropole.fr
Firefox 102.14.0esr (32 bits)
image

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@dsuren1
Copy link
Collaborator

dsuren1 commented Dec 14, 2023

Fix is required only on MS 2023.02.xx

@dsuren1
Copy link
Collaborator

dsuren1 commented Dec 19, 2023

Upstream issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment