remove all prepare emptydir workarounds #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edevosc2c
force-pushed
the
remove-prepare-emptydir
branch
from
82f07bd to
b51d853
Compare
|
LGTM. Thank you for this ! |
edevosc2c
force-pushed
the
remove-prepare-emptydir
branch
from
b51d853 to
7d81fd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since georchestra/georchestra#4030 (comment) was merged, there is now an official way to deal with small changes in the geOrchestra components.
This commit removes all the "prepare" emptyDir which were used to override files in the container before the startup.
As camptocamp relied on it a lot, for all the clients there will be a need to convert the overriding files logic into a custom script.
Close #77