Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update of request headers #460

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fix update of request headers #460

merged 1 commit into from
Apr 9, 2024

Conversation

epif4nio
Copy link
Contributor

@epif4nio epif4nio commented Sep 6, 2023

This is a fix to the issue #459

The update function changes the object but always returns None, which resulted in the value returned by get_request_headers being empty all the time.

Among other things that could happen, the Authorization header was not being sent, resulting in a 401 status.

Copy link
Member

@justb4 justb4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, took too long. But thanks for this fix (and your patience)! Indeed dict.update() returns None.

@justb4 justb4 merged commit 9af0d86 into geopython:master Apr 9, 2024
@justb4 justb4 added the bug label Apr 9, 2024
@justb4 justb4 added this to the Version 0.9.1 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants