-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datahub: Fix cutoff expanded abstract #986
Conversation
Affected libs:
|
📷 Screenshots are here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh thanks, I completely missed that. I'll have a look how to handle this. |
Is it possible that the size computation is incorrect because of fonts loading or something like that? |
35679d3
to
51d00b0
Compare
51d00b0
to
f4dd051
Compare
So as it turned out it was the |
Description
This PR replaces a margin with a padding in the max-lines ng-content to prevent cutoffs on expanded abstracts that may occur with markup since margins are not taken into account when calculating the expanded max height via
getBoundingClientRect
.The bug was detected on camptocamp/mel-dataplatform#102
Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
labelThis work is sponsored by MEL.