Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ME]: Create record by duplicating remote record. #985

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

rcaplier
Copy link
Collaborator

@rcaplier rcaplier commented Sep 5, 2024

Description

This PR introduces a new import button right next to the create button. For now the import button allow only to import with an external URL.

Screenshots

image

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by(xx).

@rcaplier rcaplier self-assigned this Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Affected libs: api-metadata-converter, feature-editor, feature-search, feature-router, feature-map, feature-dataviz, feature-record, api-repository, feature-catalog, feature-auth, ui-search, common-domain, common-fixtures, ui-elements, feature-notifications, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-layout, ui-map, ui-dataviz,
Affected apps: metadata-editor, metadata-converter, datahub, demo, webcomponents, search, datafeeder, map-viewer, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Sep 5, 2024

📷 Screenshots are here!

@rcaplier rcaplier force-pushed the me-create-record-by-duplicating-remote-record branch 3 times, most recently from f873269 to 9ce06bb Compare September 11, 2024 14:07
@rcaplier rcaplier marked this pull request as ready for review September 12, 2024 05:10
@rcaplier rcaplier force-pushed the me-create-record-by-duplicating-remote-record branch 3 times, most recently from e748008 to 4f73dd2 Compare September 12, 2024 06:29
@coveralls
Copy link

coveralls commented Sep 12, 2024

Coverage Status

coverage: 83.232% (+1.6%) from 81.648%
when pulling 6b26088 on me-create-record-by-duplicating-remote-record
into 344a92f on main.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work! It all works quite well. I tried with a few records and one of them failed for a CORS reason:

https://sextant.ifremer.fr/geonetwork/srv/api/records/dcb73aea-b8d7-406b-9110-10f007bc69b6/formatters/xml

The error was:
image

Do you think the error could be a little more helpful? Ideally mentioning CORS, or at least mentioning that the resource could not be read?

@rcaplier rcaplier force-pushed the me-create-record-by-duplicating-remote-record branch 6 times, most recently from 7fff56d to 6c8804c Compare September 13, 2024 13:34
@rcaplier rcaplier force-pushed the me-create-record-by-duplicating-remote-record branch from 6c8804c to 6b26088 Compare September 13, 2024 13:35
@rcaplier rcaplier requested a review from jahow September 13, 2024 13:36
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! There's a test failure that I'm not familiar with, but it might just be a flaky test. The rest is OK now!

@rcaplier rcaplier merged commit 575f30f into main Sep 13, 2024
14 checks passed
@rcaplier rcaplier deleted the me-create-record-by-duplicating-remote-record branch September 13, 2024 14:03
@cmoinier cmoinier mentioned this pull request Oct 24, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants