-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ME]: Create record by duplicating remote record. #985
Conversation
Affected libs:
|
📷 Screenshots are here! |
f873269
to
9ce06bb
Compare
e748008
to
4f73dd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work! It all works quite well. I tried with a few records and one of them failed for a CORS reason:
Do you think the error could be a little more helpful? Ideally mentioning CORS, or at least mentioning that the resource could not be read?
apps/metadata-editor/src/app/records/search-records/search-records-list.component.html
Outdated
Show resolved
Hide resolved
apps/metadata-editor/src/app/records/search-records/search-records-list.component.html
Outdated
Show resolved
Hide resolved
apps/metadata-editor/src/app/records/search-records/search-records-list.component.ts
Outdated
Show resolved
Hide resolved
libs/feature/editor/src/lib/components/import-record/import-record.component.html
Outdated
Show resolved
Hide resolved
libs/feature/editor/src/lib/components/import-record/import-record.component.spec.ts
Outdated
Show resolved
Hide resolved
7fff56d
to
6c8804c
Compare
6c8804c
to
6b26088
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! There's a test failure that I'm not familiar with, but it might just be a flaky test. The rest is OK now!
Description
This PR introduces a new import button right next to the create button. For now the import button allow only to import with an external URL.
Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
labelThis work is sponsored by(xx).