Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: put max upload size in field config #984

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Sep 4, 2024

Description

This PR introduces a MAX_UPLOAD_SIZE_MB parameter in the field config. For now it is fixed to 10 MB because we cannot read it from the GeoNetwork API.

Architectural changes

Screenshots

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Affected libs: feature-editor,
Affected apps: metadata-editor, datafeeder, demo,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Sep 4, 2024

📷 Screenshots are here!

@coveralls
Copy link

Coverage Status

coverage: 81.781% (-1.2%) from 82.999%
when pulling f60b198 on ME-max-upload-size
into aa68983 on main.

@jahow jahow merged commit 6f312e6 into main Sep 5, 2024
14 checks passed
@jahow jahow deleted the ME-max-upload-size branch September 5, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants