-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ME]: Contacts for metadata #974
Conversation
Affected libs:
|
📷 Screenshots are here! |
cd18cb7
to
bc969b6
Compare
6c48600
to
deed6da
Compare
8ac1eeb
to
ac45c41
Compare
ac45c41
to
f545bc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @rcaplier, code LGTM!
When testing, I was wondering if it could make sense to display the organization in the contact card (especially if no firstName
lastName
are available, as they seem optional). Could it also make sense to search on other fields than the user's name? Not sure if this is feasible.
Another small detail, "Point de contact de la metadonee" is missing accents.
Nice catch @tkohr ! @jahow, I not only fixed this french word but I gave the whole file to chatGPT 4o and ask it not to change any chosen word but only fix the typos and grammatical error. It take quite some time but the result is very good, looking at the diff. Also, I did it for the english translation file. So we have a nice typo free app just before release 😃 Concerning the two other point we will adress them in another ticket since we need to release the alpha very soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes to the translations, thanks!
Description
This PR introduces the record field Contacts for metadata.
Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
labelThis work is sponsored by Organization ABC.