Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ME]: Contacts for metadata #974

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Conversation

rcaplier
Copy link
Collaborator

Description

This PR introduces the record field Contacts for metadata.

Screenshots

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by Organization ABC.

@rcaplier rcaplier self-assigned this Aug 26, 2024
Copy link
Contributor

github-actions bot commented Aug 26, 2024

Affected libs: common-fixtures, api-metadata-converter, feature-search, feature-router, feature-map, feature-dataviz, feature-record, api-repository, feature-catalog, feature-editor, feature-auth, ui-search, ui-elements, feature-notifications, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-layout, ui-map,
Affected apps: metadata-converter, metadata-editor, datahub, demo, webcomponents, search, map-viewer, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Aug 26, 2024

📷 Screenshots are here!

@rcaplier rcaplier force-pushed the me-record-field-contacts-for-metadata branch 2 times, most recently from cd18cb7 to bc969b6 Compare August 29, 2024 06:56
@rcaplier rcaplier force-pushed the me-record-field-contacts-for-metadata branch from 6c48600 to deed6da Compare September 23, 2024 07:30
@rcaplier rcaplier marked this pull request as ready for review September 23, 2024 11:28
@rcaplier rcaplier force-pushed the me-record-field-contacts-for-metadata branch from 8ac1eeb to ac45c41 Compare September 23, 2024 14:50
@rcaplier rcaplier force-pushed the me-record-field-contacts-for-metadata branch from ac45c41 to f545bc4 Compare September 23, 2024 15:09
@coveralls
Copy link

coveralls commented Sep 23, 2024

Coverage Status

coverage: 83.406% (+1.2%) from 82.189%
when pulling 90201e2 on me-record-field-contacts-for-metadata
into e5f8e61 on main.

Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rcaplier, code LGTM!

When testing, I was wondering if it could make sense to display the organization in the contact card (especially if no firstName lastName are available, as they seem optional). Could it also make sense to search on other fields than the user's name? Not sure if this is feasible.

Another small detail, "Point de contact de la metadonee" is missing accents.

@rcaplier
Copy link
Collaborator Author

rcaplier commented Sep 25, 2024

Thanks, @rcaplier, code LGTM!

When testing, I was wondering if it could make sense to display the organization in the contact card (especially if no firstName lastName are available, as they seem optional). Could it also make sense to search on other fields than the user's name? Not sure if this is feasible.

Another small detail, "Point de contact de la metadonee" is missing accents.

Nice catch @tkohr ! @jahow, I not only fixed this french word but I gave the whole file to chatGPT 4o and ask it not to change any chosen word but only fix the typos and grammatical error. It take quite some time but the result is very good, looking at the diff. Also, I did it for the english translation file. So we have a nice typo free app just before release 😃

Concerning the two other point we will adress them in another ticket since we need to release the alpha very soon.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes to the translations, thanks!

@rcaplier rcaplier merged commit d3529f0 into main Sep 25, 2024
14 checks passed
@rcaplier rcaplier deleted the me-record-field-contacts-for-metadata branch September 25, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants