[ME] Attached resources field #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affected libs:
|
jahow
force-pushed
the
ME-attached-resources
branch
from
ec6ddb9 to
5b090ac
Compare
|
📷 Screenshots are here! |
jahow
force-pushed
the
ME-attached-resources
branch
5 times, most recently
from
47c6139 to
7304c54
Compare
jahow
force-pushed
the
ME-attached-resources
branch
6 times, most recently
from
27f5a42 to
e074ac0
Compare
LHBruneton-C2C
approved these changes
Sep 3, 2024
| @@ -0,0 +1,12 @@ | |||
| <gn-ui-file-input | |||
| [maxSizeMB]="10" | |||
There was a problem hiding this comment.
Didn't we say this should be read from the server configuration?
There was a problem hiding this comment.
right!! I forgot that... I'll do it in another PR as it also applies to the overviews
libs/feature/editor/src/lib/components/record-form/form-field/form-field.component.spec.ts
Outdated
Show resolved
Hide resolved
...orm/form-field/form-field-attached-resources/form-field-attached-resources.component.spec.ts
Outdated
Show resolved
Hide resolved
… records This change renames the "distributions" field to "onlineResources" on dataset records, similarly to the service records This way, both kinds of records have the same property name, which makes sense because this property contains a mix of online resources The type of the online resources is different for datasets and services, but having the property named the same should simplify things down the line
add missing import too
nx g component online-resource-card --project feature-editor --style=css --changeDetection=OnPush --standalone --path=libs/feature/editor/src/lib/components
The attachedResources field is not preset yet in the model and is simply read from the facade. Eventually it might be put in its own field for simplicity Also adjusts the sortable list to use a proper gn-ui-button
The overview form field works similarly to the attached resources one. The intermediary "overview-upload" component was removed and everything is done in form-field-overviews component. Reading the attachments on overview change has been removed as we don't delete the attachments anymore.
…omponentOutlet This should simplify usage and allow binding output events to the sortable items more easily
This includes: attached-resources, temporal-extents and contacts
Renamed the attached-resources form field component to online-link-resources to match the model terminology
jahow
force-pushed
the
ME-attached-resources
branch
from
5d2233c to
25cf5fe
Compare
jahow
force-pushed
the
ME-attached-resources
branch
from
25cf5fe to
6bf675c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the "attached resources" field in the editor. This brought several changes:
distributionsfield originally used for online resources in the DatasetRecord model has been renamed toonlineResources; this is now the same as for ServiceRecord, which will make things easier in the future (hopefully)onlineResourceswill be used both for attached resources and distributions, endpoints etc; and we don't want to have a separate field for each in the modelRemaining to do:
save file size and mime type in uploaded resourcesArchitectural changes
The platform service now handles reading a record's attachments as well as uploading new files.
The SortableList component was moved to the
ui/layoutlib.Screenshots
Quality Assurance Checklist
breaking changelabelbackport <release branch>labelThis work is sponsored by Organization ABC.