Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub: Display search filter topic label in plural #956

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Aug 2, 2024

Description

This PR introduces proposes to change topic to topics in the search filter labels (just like formats). It might be worth discussing if we should display all search filter labels rather in plural or singular.

Also adds a small refinement on the geo badge.

Screenshot

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by geo2france.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Affected libs: ``,
Affected apps: datahub,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 82.903% (+1.9%) from 80.977%
when pulling 09e8c72 on dh-css-and-translations
into a1bcfe2 on main.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

📷 Screenshots are here!

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@tkohr tkohr merged commit aa5f997 into main Aug 5, 2024
11 checks passed
@tkohr tkohr deleted the dh-css-and-translations branch August 5, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants