Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ME: delete a record and its draft, delete a draft without record #950

Merged
merged 13 commits into from
Aug 19, 2024

Conversation

LHBruneton-C2C
Copy link
Collaborator

@LHBruneton-C2C LHBruneton-C2C commented Jul 25, 2024

Description

This PR introduces deleting of a record and its draft, or a draft without, but not rollback of draft with a record.

Architectural changes

The testing tool ng-mocks was added to the devDeps, and used in the files already concerned by this PR.

Screenshots

image
image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Jul 25, 2024

Affected libs: api-metadata-converter, feature-search, feature-router, feature-map, feature-dataviz, feature-record, api-repository, feature-catalog, feature-editor, feature-auth, ui-search, common-domain, common-fixtures, util-shared, ui-elements, feature-notifications, ui-catalog, ui-widgets, ui-inputs, ui-layout, ui-map, ui-dataviz, data-access-datafeeder, util-data-fetcher, data-access-gn4, util-app-config, util-i18n,
Affected apps: metadata-editor, metadata-converter, datahub, demo, webcomponents, map-viewer, search, datafeeder, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Jul 25, 2024

📷 Screenshots are here!

@LHBruneton-C2C LHBruneton-C2C changed the title feat(editor): remove unnecessary export ME: delete a record and its draft, delete a draft without record Aug 2, 2024
@LHBruneton-C2C LHBruneton-C2C marked this pull request as ready for review August 7, 2024 11:16
@LHBruneton-C2C
Copy link
Collaborator Author

@Angi-Kinas If you want, you can do a first review of this PR. I'll try to setup ng-mocks in a dedicated commit.

Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LHBruneton-C2C for the clean code and the ng-mocks (which looks like a game changer for the unit tests).

I left some comments, but haven't tested the functionality yet. But code wise it looks good 👍

@LHBruneton-C2C LHBruneton-C2C force-pushed the ME/delete-record branch 2 times, most recently from 3eb6c5f to 217337d Compare August 8, 2024 12:05
@coveralls
Copy link

coveralls commented Aug 8, 2024

Coverage Status

coverage: 83.548% (+0.6%) from 82.966%
when pulling eeb79bd on ME/delete-record
into 618ec56 on main.

@jahow
Copy link
Collaborator

jahow commented Aug 14, 2024

@LHBruneton-C2C thank you for starting with ng-mocks, don't forget to include this in the best practices (to rename "code guide") in the docs!

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, very good work!! Also nice job on the E2E tests 🙂

I made a few comments on top of what we discussed. I'll give a last review once you make the modifications on the records repository. Please let me know if anything is unclear. Thanks!

@jahow
Copy link
Collaborator

jahow commented Aug 14, 2024

oh also feel free to rebase to have the e2e tests actually working from time to time :)

@LHBruneton-C2C
Copy link
Collaborator Author

TODO: documentation!!!

@LHBruneton-C2C LHBruneton-C2C merged commit a9a6128 into main Aug 19, 2024
11 checks passed
@LHBruneton-C2C LHBruneton-C2C deleted the ME/delete-record branch August 19, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants