-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ME: delete a record and its draft, delete a draft without record #950
Conversation
Affected libs:
|
4f8a533
to
767ab89
Compare
📷 Screenshots are here! |
de2f098
to
691eaa4
Compare
@Angi-Kinas If you want, you can do a first review of this PR. I'll try to setup ng-mocks in a dedicated commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LHBruneton-C2C for the clean code and the ng-mocks (which looks like a game changer for the unit tests).
I left some comments, but haven't tested the functionality yet. But code wise it looks good 👍
libs/ui/search/src/lib/results-table/results-table.component.ts
Outdated
Show resolved
Hide resolved
libs/ui/search/src/lib/results-table/action-menu/action-menu.component.ts
Outdated
Show resolved
Hide resolved
libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.ts
Show resolved
Hide resolved
libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.stories.ts
Outdated
Show resolved
Hide resolved
libs/feature/search/src/lib/results-table/results-table-container.component.spec.ts
Show resolved
Hide resolved
3eb6c5f
to
217337d
Compare
@LHBruneton-C2C thank you for starting with ng-mocks, don't forget to include this in the best practices (to rename "code guide") in the docs! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, very good work!! Also nice job on the E2E tests 🙂
I made a few comments on top of what we discussed. I'll give a last review once you make the modifications on the records repository. Please let me know if anything is unclear. Thanks!
libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.html
Show resolved
Hide resolved
libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.stories.ts
Show resolved
Hide resolved
libs/ui/search/src/lib/results-table/results-table.component.ts
Outdated
Show resolved
Hide resolved
oh also feel free to rebase to have the e2e tests actually working from time to time :) |
b046109
to
e39068d
Compare
TODO: documentation!!! |
e39068d
to
eeb79bd
Compare
Description
This PR introduces deleting of a record and its draft, or a draft without, but not rollback of draft with a record.
Architectural changes
The testing tool ng-mocks was added to the devDeps, and used in the files already concerned by this PR.
Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label