Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing: Allow implementing other search routes than /search in other router services #850

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Routing: Allow implementing other search routes than /search in other router services #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/datahub/src/app/router/datahub-router.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,6 @@ export class DatahubRouterService {
}

getSearchRoute(): string {
return `${ROUTER_ROUTE_HOME}/${ROUTER_ROUTE_SEARCH}`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite curious that this always worked

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, maybe due to the redirect in lines https://github.com/geonetwork/geonetwork-ui/pull/850/files#diff-18147f3d9fd25936e42e709dea85cb97a42c69b44e19d92cde9d43f409ad6baaR30-R34 above...

return ROUTER_ROUTE_SEARCH
}
}
4 changes: 3 additions & 1 deletion libs/feature/router/src/lib/default/state/router.facade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ export class RouterFacade {

searchParams$ = this.currentRoute$.pipe(
filter((route) => !!route),
filter((route) => route.url[0]?.path.startsWith(ROUTER_ROUTE_SEARCH)),
filter((route) =>
route.url[0]?.path.startsWith(this.routerService.getSearchRoute())
),
map((route) => route.queryParams),
distinctUntilChanged((a, b) => JSON.stringify(a) === JSON.stringify(b))
)
Expand Down
Loading