Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dh): move keywords back below abstract, improve badges #835

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Mar 25, 2024

Description

This PR moves the keywords back to their original place to make them more visible and accessible.

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

@jahow
Copy link
Collaborator Author

jahow commented Mar 25, 2024

Do not merge this yet, waiting for approval

Copy link
Contributor

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search, ui-widgets, feature-editor, ui-inputs, ui-layout,
Affected apps: metadata-editor, datahub, demo, webcomponents, map-viewer, search, datafeeder, metadata-converter,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 82.197% (-1.2%) from 83.385%
when pulling 34b395d on dh-move-keywords-back
into c319ec6 on main.

Copy link
Contributor

📷 Screenshots are here!

@jahow jahow added this to the 2.2.0 milestone Apr 8, 2024
Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jahow!
LGTM 🚀

@jahow jahow merged commit e441b92 into main Apr 8, 2024
9 checks passed
@jahow jahow deleted the dh-move-keywords-back branch April 8, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants