-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI inputs: Fix typings #800
Conversation
select(choice: Choice, checked: boolean | Event) { | ||
const selected = | ||
checked instanceof Event | ||
? (checked.target as HTMLInputElement).checked | ||
: checked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't like this but couldn't find a better solution.
Affected libs:
|
2ecc94d
to
37a8203
Compare
that cause issue when reusing/extending the components
37a8203
to
e44adb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reworked in pair programming!
to allow building npm package `node generate-package.js`
Thanks for the help finding a better solution @jahow ! |
This PR fixes some typings in the
dropdown-multiselect.component
andfilter-dropdown.component
that cause issues when reusing and extending these components in a different project.Quality Assurance Checklist
breaking change
labelbackport <release branch>
labelThis work is sponsored by MEL.